samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yan Fang" <yanfang...@gmail.com>
Subject Re: Review Request 27156: SAMZA-444
Date Mon, 27 Oct 2014 16:56:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27156/#review58621
-----------------------------------------------------------



samza-core/src/main/java/org/apache/samza/job/model/ContainerModel.java
<https://reviews.apache.org/r/27156/#comment99680>

    It's a little confusing. Sounds to me like this model "represent a SamzaContainer", and
then is used in the "SamzaContainer".



samza-core/src/main/java/org/apache/samza/job/model/JobModel.java
<https://reviews.apache.org/r/27156/#comment99681>

    can we also include this part in all ContainerModel, TaskModel? Otherwise, when users
only read one of the models, they do not have any ideas abut the hierarchy.


- Yan Fang


On Oct. 24, 2014, 9:08 p.m., Chris Riccomini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27156/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2014, 9:08 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-444
>     https://issues.apache.org/jira/browse/SAMZA-444
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> remove JsonConfigSerializer in favor of proper jackson bindings
> 
> 
> re-enable all tests in samza container
> 
> 
> add docs. add timeout to Util.read
> 
> 
> enable group by container count test again
> 
> 
> add javadocs
> 
> 
> re-enable process job
> 
> 
> make tests work again
> 
> 
> switch to proper mixins for jackson
> 
> 
> add job coordinator test
> 
> 
> move util methods into job coordinator
> 
> 
> fully functional AM, but container is failing
> 
> 
> add json serde using jackson
> 
> 
> fix GroupByContainerCount
> 
> 
> add job, container, and task data model. update samza container to use it
> 
> 
> Diffs
> -----
> 
>   samza-core/src/main/java/org/apache/samza/job/model/ContainerModel.java PRE-CREATION

>   samza-core/src/main/java/org/apache/samza/job/model/JobModel.java PRE-CREATION 
>   samza-core/src/main/java/org/apache/samza/job/model/TaskModel.java PRE-CREATION 
>   samza-core/src/main/java/org/apache/samza/serializers/model/JsonContainerModelMixIn.java
PRE-CREATION 
>   samza-core/src/main/java/org/apache/samza/serializers/model/JsonTaskModelMixIn.java
PRE-CREATION 
>   samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java
PRE-CREATION 
>   samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala 64a5078e316708c92e3f8c75e92416b2545b01d1

>   samza-core/src/main/scala/org/apache/samza/config/serializers/JsonConfigSerializer.scala
60e65ea29cbfc2212239c288618830f49a0669c6 
>   samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala d0c90048fa2b3a153e9dc9565619d117f098525b

>   samza-core/src/main/scala/org/apache/samza/container/TaskNamesToSystemStreamPartitions.scala
da15346eb2e35e72ec20101f5e0d677d45f28acf 
>   samza-core/src/main/scala/org/apache/samza/container/grouper/task/GroupByContainerCount.scala
7a3ba46b50f6fe4936919cefd669205cb21d4a0f 
>   samza-core/src/main/scala/org/apache/samza/container/grouper/task/TaskNameGrouper.scala
46e75b191e00ff5064436723ecf1b547f5ce8082 
>   samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala PRE-CREATION

>   samza-core/src/main/scala/org/apache/samza/coordinator/server/HttpServer.scala 7c0676c9b2961b92317e3a423ff48f4e901ccba2

>   samza-core/src/main/scala/org/apache/samza/coordinator/server/JobServlet.scala d7841a6d721ab48e1f29318b2abc49fc63388312

>   samza-core/src/main/scala/org/apache/samza/coordinator/server/ServletBase.scala c9bad90e68bd16ed93429e9a2b3c346bc150bc3f

>   samza-core/src/main/scala/org/apache/samza/job/local/ProcessJob.scala bd38955e3a5a111afa93c9151cdd8144ac650088

>   samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala b1e5237abeae350900c41d9873e3c6d54aa0c94e

>   samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala 4d5f0d540a35714a0ad1f71f300f82b3e1537dfd

>   samza-core/src/main/scala/org/apache/samza/util/JsonHelpers.scala e3f23b679af1dcc7212e784ad58f0e41a5580d6c

>   samza-core/src/main/scala/org/apache/samza/util/Util.scala e06ca90d2b93e1b86ced6c9689e99bab39071eb4

>   samza-core/src/test/java/org/apache/samza/serializers/model/TestSamzaObjectMapper.java
PRE-CREATION 
>   samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 393b09a530ae56fc9017cf9e7ca2a58351a44056

>   samza-core/src/test/scala/org/apache/samza/container/TestTaskNamesToSystemStreamPartitions.scala
9a3406e821988337274c063b7f369a58a958f0ba 
>   samza-core/src/test/scala/org/apache/samza/container/grouper/task/TestGroupByContainerCount.scala
20f41a846ae22cae8b89f1289fd2ddb32dc695b7 
>   samza-core/src/test/scala/org/apache/samza/coordinator/TestJobCoordinator.scala PRE-CREATION

>   samza-core/src/test/scala/org/apache/samza/util/TestUtil.scala 93c71b4a68ebb0c9221203a7fd88280745f32209

>   samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml 50a742629e049922a3985da94cdcb39a5a2d8d71

>   samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala 723b673a7e84220b02e8a5cdd0f67cc9c2a6e5d3

>   samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterService.scala b0769681961ce60dca03346f3e275f15435f3a91

>   samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala 423e9035dcb701297adc3022c478cdc0ad7726b5

>   samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala
eb5252906132fc88636ea5c1e6afc96e110d8d4b 
>   samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJob.scala d7aa24014a3bf92660b2be55dbd6677de02c7fa4

>   samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala
d6cf22d6da077d4554d127f620c5170a7c0686ce 
>   samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterService.scala
a1c090d927602547b894f4c737ca03b777454c50 
>   samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala
5f65dbd9aa6a9da6039615f95fe0f000f8a8558e 
> 
> Diff: https://reviews.apache.org/r/27156/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris Riccomini
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message