samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Riccomini" <criccom...@apache.org>
Subject Re: Review Request 30781: SAMZA-548
Date Thu, 12 Feb 2015 21:13:27 GMT


> On Feb. 9, 2015, 7:52 p.m., Navina Ramesh wrote:
> > samza-test/src/main/python/samza_job_yarn_deployer.py, line 204
> > <https://reviews.apache.org/r/30781/diff/1/?file=858127#file858127line204>
> >
> >     What are the final job states that is returned by Yarn?

It can be any of FINAL, FAILED, etc. I'm honestly not sure. I just know that a running job
is UNDEFINED.


> On Feb. 9, 2015, 7:52 p.m., Navina Ramesh wrote:
> > samza-test/src/main/python/tests/performance_tests.py, line 77
> > <https://reviews.apache.org/r/30781/diff/1/?file=858129#file858129line77>
> >
> >     What is the purpose of this if statement ?

Just to limit the number of "loaded" messages so that the console buffer doesn't get really
hug. We log every 100k messages.


- Chris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30781/#review71680
-----------------------------------------------------------


On Feb. 12, 2015, 9:11 p.m., Chris Riccomini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30781/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2015, 9:11 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-548
>     https://issues.apache.org/jira/browse/SAMZA-548
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> upgrade integration test to 0.8.2.0 kafka
> 
> 
> import patch
> 
> 
> Diffs
> -----
> 
>   samza-shell/src/main/bash/stat-yarn-job.sh PRE-CREATION 
>   samza-test/src/main/config/negate-number.properties 379fa610284291c32bbd73de67c0ecb295734e06

>   samza-test/src/main/config/perf/kafka-read-write-performance.properties PRE-CREATION

>   samza-test/src/main/java/org/apache/samza/test/integration/NegateNumberTask.java 782e9f43358549db2007ad71b1d4d9e8e9be5440

>   samza-test/src/main/python/configs/downloads.json 8ded306c8b0965cf51f14150d058aeeaa2b20219

>   samza-test/src/main/python/configs/kafka.json 9a7af19ba2c3d3ad698aad58158986e32ba01cab

>   samza-test/src/main/python/configs/smoke-tests/smoke-tests.json 65f85682ff77c5a0b2245b9523e7aec917e64d19

>   samza-test/src/main/python/deployment.py a0e14819b8ff2ea86fb22c4a7e59a8adf2288458 
>   samza-test/src/main/python/samza_job_yarn_deployer.py e18bc581f287938ec82b7fe6fbd11d29f13a373c

>   samza-test/src/main/python/tests.py dae414ecabe7374d4ee020b5788ce95ba3d583af 
>   samza-test/src/main/python/tests/performance_tests.py PRE-CREATION 
>   samza-test/src/main/python/tests/smoke_tests.py 7aec4e0d1f30539dd446ffaea7bfabf05ed7c410

>   samza-test/src/main/python/tests/util.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/30781/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris Riccomini
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message