samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yan Fang" <yanfang...@gmail.com>
Subject Re: Review Request 31034: SAMZA-479: Make StreamAppender pluggable for different log formats
Date Wed, 18 Feb 2015 21:36:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31034/
-----------------------------------------------------------

(Updated Feb. 18, 2015, 9:36 p.m.)


Review request for samza.


Bugs: SAMZA-479
    https://issues.apache.org/jira/browse/SAMZA-479


Repository: samza


Description
-------

modifed StreamAppender to accept different serdes
added LoggingEventStringSerde
added unit tests


Diffs (updated)
-----

  samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java 659e3b6 
  samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java 9a9d648 
  samza-log4j/src/main/java/org/apache/samza/logging/log4j/serializers/LoggingEventStringSerde.java
PRE-CREATION 
  samza-log4j/src/main/java/org/apache/samza/logging/log4j/serializers/LoggingEventStringSerdeFactory.java
PRE-CREATION 
  samza-log4j/src/test/java/org/apache/samza/config/TestLog4jSystemConfig.java 64a1e70 
  samza-log4j/src/test/java/org/apache/samza/logging/log4j/TestStreamAppender.java 46e4b8c

  samza-log4j/src/test/java/org/apache/samza/logging/log4j/serializers/TestLoggingEventStringSerde.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/31034/diff/


Testing
-------


Thanks,

Yan Fang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message