samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Riccomini" <criccom...@apache.org>
Subject Review Request 31910: SAMZA-505
Date Tue, 10 Mar 2015 20:52:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31910/
-----------------------------------------------------------

Review request for samza.


Bugs: SAMZA-505
    https://issues.apache.org/jira/browse/SAMZA-505


Repository: samza


Description
-------

add a safety check and warning when using byte arrays in cached store


Adding a ByteBufferSerde. Useful in cases where people want to use CachedStore with byte arrays
as a key (i.e. they have to wrap in ByteBuffer), but also want a changelog.


Diffs
-----

  build.gradle 0a268ac7a3819cf46b54a93e0e3171455371456a 
  samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 275eb1a924d09a0a43efe6273e0d2af9217e1c74

  samza-core/src/main/scala/org/apache/samza/serializers/ByteBufferSerde.scala PRE-CREATION

  samza-core/src/main/scala/org/apache/samza/serializers/ByteSerde.scala e7ce09f714bd5d0c6b764ddb3e02cda4b7c7f2e6

  samza-core/src/test/scala/org/apache/samza/serializers/TestByteBufferSerde.scala PRE-CREATION

  samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala 84cf6db3a1b035c639a6dec30fe9ee997b282a80

  samza-kv/src/test/scala/org/apache/samza/storage/kv/TestCachedStore.scala PRE-CREATION 

Diff: https://reviews.apache.org/r/31910/diff/


Testing
-------


Thanks,

Chris Riccomini


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message