samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naveen Somasundaram" <navg...@gmail.com>
Subject Re: Review Request 32127: SAMZA-586
Date Tue, 17 Mar 2015 21:23:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32127/#review76817
-----------------------------------------------------------



samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala
<https://reviews.apache.org/r/32127/#comment124475>

    https://issues.apache.org/jira/browse/SAMZA-393 seems to be something else ?


- Naveen Somasundaram


On March 17, 2015, 7:01 a.m., Chris Riccomini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32127/
> -----------------------------------------------------------
> 
> (Updated March 17, 2015, 7:01 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> fix compression.type in kafka checkpoint manager. add test for kafka system factory.
> 
> 
> add injected props for producer to disable compression
> 
> 
> Diffs
> -----
> 
>   samza-core/src/main/scala/org/apache/samza/config/StorageConfig.scala f977b8bd1f20386175d0dd79a9844f1b5394f84c

>   samza-core/src/test/scala/org/apache/samza/config/TestStorageConfig.scala PRE-CREATION

>   samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala
7fc6d89b5d703a7c10a212aaa8d3f9231996b897 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemFactory.scala 4f15002325bc0154991f9a35312e903d15ef81e7

>   samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemFactory.scala
5f65144146109418b4ec2ac40b3a69cb97f26224 
> 
> Diff: https://reviews.apache.org/r/32127/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris Riccomini
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message