samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navina Ramesh" <nram...@linkedin.com>
Subject Re: Review Request 32188: Disable WAL in RocksDB KV store
Date Wed, 18 Mar 2015 21:57:20 GMT


> On March 18, 2015, 9:56 p.m., Yi Pan (Data Infrastructure) wrote:
> > samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala,
line 135
> > <https://reviews.apache.org/r/32188/diff/1/?file=898491#file898491line135>
> >
> >     nit: do we need multiple instances of ByteSerde here?

Ah..not really. Will change that.


- Navina


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32188/#review76954
-----------------------------------------------------------


On March 18, 2015, 9:48 p.m., Navina Ramesh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32188/
> -----------------------------------------------------------
> 
> (Updated March 18, 2015, 9:48 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Adding KV write performance test
> 
> 
> Diffs
> -----
> 
>   samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala
14eeba5e7569ebd7f9096b0b8f30117e4fe3434b 
>   samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala
eae2a5af665e5da1cf007ee39ee5a79e558f11d6 
>   samza-test/src/main/config/perf/kv-perf.properties 0d487b171cedf017a8711675af7bc5bfb0d029df

>   samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala
b4fa7d3575e3b81ea3b606a1de8f06cedb87168a 
> 
> Diff: https://reviews.apache.org/r/32188/diff/
> 
> 
> Testing
> -------
> 
> ./bin/check-all.sh ran successfully on MAC
> 
> 
> Thanks,
> 
> Navina Ramesh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message