samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navina Ramesh" <nram...@linkedin.com>
Subject Re: Review Request 32155: SAMZA-458: Close in KafkaSystemProducer should flush all source buffers
Date Fri, 20 Mar 2015 22:41:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32155/#review77293
-----------------------------------------------------------

Ship it!


Ship It!

- Navina Ramesh


On March 20, 2015, 9:40 p.m., Yan Fang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32155/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 9:40 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-458
>     https://issues.apache.org/jira/browse/SAMZA-458
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> add flush in close method
> only throw exceptions after flushing all sources
> add unit test
> 
> 
> Diffs
> -----
> 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala
83668dd 
>   samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala
ca10ea5 
> 
> Diff: https://reviews.apache.org/r/32155/diff/
> 
> 
> Testing
> -------
> 
> ran unit tests and integration test
> 
> 
> Thanks,
> 
> Yan Fang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message