samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>
Subject Re: Review Request 32407: SAMZA-571: add suppression interface for uncaught exceptions
Date Wed, 25 Mar 2015 02:24:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32407/
-----------------------------------------------------------

(Updated March 25, 2015, 2:24 a.m.)


Review request for samza, Yan Fang, Chinmay Soman, Chris Riccomini, Navina Ramesh, and Naveen
Somasundaram.


Changes
-------

Revised: add more exception callback methods to ExceptionTask interface for each specific
task lifecycle stage. Consolidate invocation of ExceptionTask.exception() and the configured
suppression in a single place.


Bugs: SAMZA-571
    https://issues.apache.org/jira/browse/SAMZA-571


Repository: samza


Description (updated)
-------

[SAMZA-571] Adding task interface to allow customized handling of exceptions from user code
in tasks

Just to add the first part: add ExceptionTask interface to allow user to add code to handle
the exceptions from user code in the task's lifecycle: init(), process(), window(), and close().


Diffs (updated)
-----

  samza-api/src/main/java/org/apache/samza/task/ExceptionTask.java PRE-CREATION 
  samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 9fc3b557bdcc2756a0ddfed6642deb529936b7a9

  samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala be0b55ace5b4b9d29f42da17fabac93bb6a25605

  samza-core/src/main/scala/org/apache/samza/container/TaskInstanceExceptionHandler.scala
99b729f129344dee7d324d5889a3964c331f6521 
  samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala 54b4df84f47f818d62ac0361196567ad1f430fde


Diff: https://reviews.apache.org/r/32407/diff/


Testing (updated)
-------

Unit tests added. Pass with ./bin/check-all.sh


Thanks,

Yi Pan (Data Infrastructure)


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message