samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>
Subject Re: Review Request 33170: Renamed samza-sql to samza-sql-core
Date Tue, 14 Apr 2015 16:58:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33170/#review80043
-----------------------------------------------------------

Ship it!


I assume that those files w/ Calcite dependencies moved to samza-sql-calcite later.


samza-sql-core/README.md
<https://reviews.apache.org/r/33170/#comment129800>

    We may want to add a few more description here, like samza-sql-core is the module for
backend operators and samza-sql-calcite is the module for front end parser/planner.



samza-sql-core/src/main/java/org/apache/samza/sql/metadata/AvroSchemaConverter.java
<https://reviews.apache.org/r/33170/#comment129803>

    We should consider moving this to samza-sql-calcite, when the module is created.



samza-sql-core/src/main/java/org/apache/samza/sql/planner/QueryPlanner.java
<https://reviews.apache.org/r/33170/#comment129805>

    This should be moved to samza-sql-calcite as well.



samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaCalciteConnection.java
<https://reviews.apache.org/r/33170/#comment129806>

    Same here.



samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaQueryPreparingStatement.java
<https://reviews.apache.org/r/33170/#comment129808>

    move to samza-sql-calcite.



samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaSqlValidator.java
<https://reviews.apache.org/r/33170/#comment129809>

    Same here.



samza-sql-core/src/test/java/org/apache/samza/sql/planner/QueryPlannerTest.java
<https://reviews.apache.org/r/33170/#comment129811>

    Move to samza-sql-calcite



samza-sql-core/src/test/java/org/apache/samza/sql/planner/SamzaStreamTableFactory.java
<https://reviews.apache.org/r/33170/#comment129814>

    Move to samza-sql-calcite



samza-sql-core/src/test/java/org/apache/samza/sql/test/metadata/TestAvroSchemaConverter.java
<https://reviews.apache.org/r/33170/#comment129816>

    Same here.


- Yi Pan (Data Infrastructure)


On April 14, 2015, 3:14 p.m., Milinda Pathirage wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33170/
> -----------------------------------------------------------
> 
> (Updated April 14, 2015, 3:14 p.m.)
> 
> 
> Review request for samza, Chris Riccomini and Yi Pan (Data Infrastructure).
> 
> 
> Bugs: SAMZA-648
>     https://issues.apache.org/jira/browse/SAMZA-648
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> This patch rename samza-sql module to samza-sql-core. This is the first step of separating
samza-sql to multiple modules. samza-sql-core will contain operator layer related code while
we will have separate modules for different front-end implementations. After this step, Calcite
based front-end code will be moved to samza-sql-calcite module.
> 
> 
> Diffs
> -----
> 
>   build.gradle ee4baa5 
>   gradle/dependency-versions.gradle 46e7c28 
>   samza-sql-core/README.md PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Data.java PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/api/data/EntityName.java PRE-CREATION

>   samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Relation.java PRE-CREATION

>   samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Schema.java PRE-CREATION

>   samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Tuple.java PRE-CREATION

>   samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/Operator.java PRE-CREATION

>   samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/RelationOperator.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/SqlOperatorFactory.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/TupleOperator.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/spec/OperatorSpec.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/api/router/OperatorRouter.java PRE-CREATION

>   samza-sql-core/src/main/java/org/apache/samza/sql/data/IncomingMessageTuple.java PRE-CREATION

>   samza-sql-core/src/main/java/org/apache/samza/sql/data/avro/AvroData.java PRE-CREATION

>   samza-sql-core/src/main/java/org/apache/samza/sql/data/avro/AvroSchema.java PRE-CREATION

>   samza-sql-core/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerde.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeFactory.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/data/serializers/SqlStringSerde.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/data/serializers/SqlStringSerdeFactory.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/data/string/StringData.java PRE-CREATION

>   samza-sql-core/src/main/java/org/apache/samza/sql/data/string/StringSchema.java PRE-CREATION

>   samza-sql-core/src/main/java/org/apache/samza/sql/metadata/AvroSchemaConverter.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperator.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorFactoryImpl.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorSpec.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/PartitionOp.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/PartitionSpec.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/operators/relation/Join.java PRE-CREATION

>   samza-sql-core/src/main/java/org/apache/samza/sql/operators/relation/JoinSpec.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/operators/stream/InsertStream.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/operators/stream/InsertStreamSpec.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/BoundedTimeWindow.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowSpec.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowState.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/planner/QueryPlanner.java PRE-CREATION

>   samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaCalciteConnection.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaQueryPreparingStatement.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaSqlValidator.java PRE-CREATION

>   samza-sql-core/src/main/java/org/apache/samza/sql/router/SimpleRouter.java PRE-CREATION

>   samza-sql-core/src/main/java/org/apache/samza/task/sql/OperatorMessageCollector.java
PRE-CREATION 
>   samza-sql-core/src/main/java/org/apache/samza/task/sql/SqlMessageCollector.java PRE-CREATION

>   samza-sql-core/src/main/java/org/apache/samza/task/sql/StoreMessageCollector.java PRE-CREATION

>   samza-sql-core/src/test/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeTest.java
PRE-CREATION 
>   samza-sql-core/src/test/java/org/apache/samza/sql/planner/QueryPlannerTest.java PRE-CREATION

>   samza-sql-core/src/test/java/org/apache/samza/sql/planner/SamzaStreamTableFactory.java
PRE-CREATION 
>   samza-sql-core/src/test/java/org/apache/samza/sql/test/metadata/TestAvroSchemaConverter.java
PRE-CREATION 
>   samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomOperatorTask.java PRE-CREATION

>   samza-sql-core/src/test/java/org/apache/samza/task/sql/StreamSqlTask.java PRE-CREATION

>   samza-sql/README.md 598670b 
>   samza-sql/src/main/java/org/apache/samza/sql/api/data/Data.java d1b8409 
>   samza-sql/src/main/java/org/apache/samza/sql/api/data/EntityName.java 127a677 
>   samza-sql/src/main/java/org/apache/samza/sql/api/data/Relation.java 90b8026 
>   samza-sql/src/main/java/org/apache/samza/sql/api/data/Schema.java 1e8f192 
>   samza-sql/src/main/java/org/apache/samza/sql/api/data/Tuple.java bc8efcf 
>   samza-sql/src/main/java/org/apache/samza/sql/api/operators/Operator.java 0169f2d 
>   samza-sql/src/main/java/org/apache/samza/sql/api/operators/RelationOperator.java faa0a32

>   samza-sql/src/main/java/org/apache/samza/sql/api/operators/SqlOperatorFactory.java
67671b9 
>   samza-sql/src/main/java/org/apache/samza/sql/api/operators/TupleOperator.java ac4654e

>   samza-sql/src/main/java/org/apache/samza/sql/api/operators/spec/OperatorSpec.java 96385e2

>   samza-sql/src/main/java/org/apache/samza/sql/api/router/OperatorRouter.java 2455a62

>   samza-sql/src/main/java/org/apache/samza/sql/data/IncomingMessageTuple.java f868e5c

>   samza-sql/src/main/java/org/apache/samza/sql/data/avro/AvroData.java d040be9 
>   samza-sql/src/main/java/org/apache/samza/sql/data/avro/AvroSchema.java 577cf74 
>   samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerde.java f3f7f7d

>   samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeFactory.java
aad18f4 
>   samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlStringSerde.java 1f0c3b2

>   samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlStringSerdeFactory.java
2564479 
>   samza-sql/src/main/java/org/apache/samza/sql/data/string/StringData.java b81d9fa 
>   samza-sql/src/main/java/org/apache/samza/sql/data/string/StringSchema.java 348fc0c

>   samza-sql/src/main/java/org/apache/samza/sql/metadata/AvroSchemaConverter.java 7cc43c0

>   samza-sql/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperator.java
c634159 
>   samza-sql/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorFactoryImpl.java
916b166 
>   samza-sql/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorSpec.java
93d4ebb 
>   samza-sql/src/main/java/org/apache/samza/sql/operators/partition/PartitionOp.java 986d688

>   samza-sql/src/main/java/org/apache/samza/sql/operators/partition/PartitionSpec.java
29d1784 
>   samza-sql/src/main/java/org/apache/samza/sql/operators/relation/Join.java a8a6eaf 
>   samza-sql/src/main/java/org/apache/samza/sql/operators/relation/JoinSpec.java ba8bfb5

>   samza-sql/src/main/java/org/apache/samza/sql/operators/stream/InsertStream.java 7563100

>   samza-sql/src/main/java/org/apache/samza/sql/operators/stream/InsertStreamSpec.java
70475ce 
>   samza-sql/src/main/java/org/apache/samza/sql/operators/window/BoundedTimeWindow.java
935ffc0 
>   samza-sql/src/main/java/org/apache/samza/sql/operators/window/WindowSpec.java e2ae3aa

>   samza-sql/src/main/java/org/apache/samza/sql/operators/window/WindowState.java 48547f0

>   samza-sql/src/main/java/org/apache/samza/sql/planner/QueryPlanner.java 16dbdc3 
>   samza-sql/src/main/java/org/apache/samza/sql/planner/SamzaCalciteConnection.java 63b1da5

>   samza-sql/src/main/java/org/apache/samza/sql/planner/SamzaQueryPreparingStatement.java
0721573 
>   samza-sql/src/main/java/org/apache/samza/sql/planner/SamzaSqlValidator.java f46c1f0

>   samza-sql/src/main/java/org/apache/samza/sql/router/SimpleRouter.java c6fc673 
>   samza-sql/src/main/java/org/apache/samza/task/sql/OperatorMessageCollector.java 1e5310f

>   samza-sql/src/main/java/org/apache/samza/task/sql/SqlMessageCollector.java b98e2d7

>   samza-sql/src/main/java/org/apache/samza/task/sql/StoreMessageCollector.java b4b0e59

>   samza-sql/src/test/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeTest.java
7412669 
>   samza-sql/src/test/java/org/apache/samza/sql/planner/QueryPlannerTest.java 36b6f03

>   samza-sql/src/test/java/org/apache/samza/sql/planner/SamzaStreamTableFactory.java f757d8f

>   samza-sql/src/test/java/org/apache/samza/sql/test/metadata/TestAvroSchemaConverter.java
b4ac5f5 
>   samza-sql/src/test/java/org/apache/samza/task/sql/RandomOperatorTask.java 4ec7dbb 
>   samza-sql/src/test/java/org/apache/samza/task/sql/StreamSqlTask.java 4796fa6 
>   settings.gradle 08e548c 
> 
> Diff: https://reviews.apache.org/r/33170/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milinda Pathirage
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message