samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Harvey" <danharve...@gmail.com>
Subject Re: Review Request 33297: [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach indexes.
Date Wed, 22 Apr 2015 16:58:42 GMT


> On April 17, 2015, 9:49 p.m., Jakob Homan wrote:
> > settings.gradle, line 33
> > <https://reviews.apache.org/r/33297/diff/1/?file=933093#file933093line33>
> >
> >     This list of non-Scala projects to check is getting too long and difficult to
read.  Can we just the relevant projects into a 'non-scala' map and check for inclusion?

I've cleaned this up so it's not repetative.


> On April 17, 2015, 9:49 p.m., Jakob Homan wrote:
> > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemAdmin.java,
line 25
> > <https://reviews.apache.org/r/33297/diff/1/?file=933090#file933090line25>
> >
> >     This is interesting... I don't imagine elasticsearch will ever be an appropriate
store for a changelog.  Should we throw an exception here?

Yes I'll throw an exception here.

Maybe if we add more systems that don't need this it can be cleaned up and there can be a
single UnsupportedSystemAdmin.


> On April 17, 2015, 9:49 p.m., Jakob Homan wrote:
> > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemFactory.java,
line 26
> > <https://reviews.apache.org/r/33297/diff/1/?file=933091#file933091line26>
> >
> >     Since the admin is doing nothing, should we just have a single instance of it
to return?

Yes added a singletion instance.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33297/#review80538
-----------------------------------------------------------


On April 17, 2015, 10:47 a.m., Dan Harvey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33297/
> -----------------------------------------------------------
> 
> (Updated April 17, 2015, 10:47 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach
indexes.
> 
> 
> Diffs
> -----
> 
>   build.gradle 97de3a28f6379e3862eec845da87587b1d4f742e 
>   gradle/dependency-versions.gradle ee6dfc411b7ab90b187df79f109884127953862e 
>   samza-elasticsearch/src/main/java/org/apache/samza/config/ElasticsearchConfig.java
PRE-CREATION 
>   samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemAdmin.java
PRE-CREATION 
>   samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemFactory.java
PRE-CREATION 
>   samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java
PRE-CREATION 
>   settings.gradle bb07a3b84b14dcef94da1bb166eab6aa3d0026bb 
> 
> Diff: https://reviews.apache.org/r/33297/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Harvey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message