samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yan Fang" <yanfang...@gmail.com>
Subject Re: Review Request 35933: SAMZA-449 Expose RocksDB statistic
Date Fri, 03 Jul 2015 23:41:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35933/#review90373
-----------------------------------------------------------



samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala (line
133)
<https://reviews.apache.org/r/35933/#comment143410>

    we can remove the "KeyValueStoreMetrics" here, right? change to "new RocksDbStatisticMetrics(storeName,
options, metrics)"



samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala (line
245)
<https://reviews.apache.org/r/35933/#comment143411>

    the "[[]]" is not very common. And I do not see anywere in Samza we are using. It's better
to remove them, or use {@link} if you want to link to the class.



samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbStatisticMetrics.scala
(line 213)
<https://reviews.apache.org/r/35933/#comment143409>

    is any code is using those methods (line 213-219)? If not, it's safe to remove them. Also,
users can directly call the variable name to get the value, if they want.


- Yan Fang


On July 3, 2015, 11:05 p.m., Gustavo Anatoly F. V. Solís wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35933/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 11:05 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> RocksDb expose statistic
> 
> 
> Diffs
> -----
> 
>   samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala
a423f7bd6c43461e051b5fd1f880dd01db785991 
>   samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbStatisticMetrics.scala
PRE-CREATION 
>   samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala
a428a16bc1e9ab4980a6f17db4fd810057d31136 
> 
> Diff: https://reviews.apache.org/r/35933/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gustavo Anatoly F. V. Solís
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message