samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From József Márton Jung <j.j...@levi9.com>
Subject Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages
Date Mon, 27 Jul 2015 10:15:40 GMT


> On July 24, 2015, 6:01 p.m., Navina Ramesh wrote:
> > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala, line
627
> > <https://reviews.apache.org/r/36545/diff/2/?file=1020934#file1020934line627>
> >
> >     LocalityManager maintains "container to host"-level mapping. Not a task to host
mapping. Please change this back to containerId.

Corected.


- József Márton


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36545/#review92938
-----------------------------------------------------------


On July 27, 2015, 10:15 a.m., József Márton Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36545/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 10:15 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> The following has been refactored: 
> 1. Static inner classes from CoordinatorStreamMessage has been extracted
> 2. Common functionality from CheckpointManager, ChangelogMappingManager and LocalityManager
has benn moved to a base class
> 
> 
> Diffs
> -----
> 
>   checkstyle/import-control.xml 6654319 
>   samza-core/src/main/java/org/apache/samza/checkpoint/CheckpointManager.java 7445996

>   samza-core/src/main/java/org/apache/samza/container/LocalityManager.java 55c258f 
>   samza-core/src/main/java/org/apache/samza/coordinator/stream/AbstractCoordinatorStreamManager.java
PRE-CREATION 
>   samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamMessage.java
e5ab4fb 
>   samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamSystemConsumer.java
b1078bd 
>   samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamSystemProducer.java
92f8907 
>   samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamWriter.java
f769756 
>   samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/CoordinatorStreamMessage.java
PRE-CREATION 
>   samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/Delete.java PRE-CREATION

>   samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/SetChangelogMapping.java
PRE-CREATION 
>   samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/SetCheckpoint.java
PRE-CREATION 
>   samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/SetConfig.java
PRE-CREATION 
>   samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/SetContainerHostMapping.java
PRE-CREATION 
>   samza-core/src/main/java/org/apache/samza/job/model/JobModel.java ad6387d 
>   samza-core/src/main/java/org/apache/samza/storage/ChangelogPartitionManager.java 7d3409c

>   samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala f621611

>   samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala 1c178a6 
>   samza-core/src/test/java/org/apache/samza/coordinator/stream/MockCoordinatorStreamWrappedConsumer.java
e454593 
>   samza-core/src/test/java/org/apache/samza/coordinator/stream/TestCoordinatorStreamMessage.java
ac26a01 
>   samza-core/src/test/java/org/apache/samza/coordinator/stream/TestCoordinatorStreamSystemConsumer.java
c25f6a7 
>   samza-core/src/test/java/org/apache/samza/coordinator/stream/TestCoordinatorStreamSystemProducer.java
1ef07d0 
>   samza-core/src/test/java/org/apache/samza/coordinator/stream/TestCoordinatorStreamWriter.java
c484660 
>   samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 84fdeaa

>   samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml 41303f7 
> 
> Diff: https://reviews.apache.org/r/36545/diff/
> 
> 
> Testing
> -------
> 
> Tests has been updated.
> 
> 
> Thanks,
> 
> József Márton Jung
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message