samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>
Subject Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer
Date Wed, 29 Jul 2015 06:02:37 GMT


> On July 29, 2015, 5:47 a.m., Yi Pan (Data Infrastructure) wrote:
> > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java,
line 149
> > <https://reviews.apache.org/r/36815/diff/4/?file=1024086#file1024086line149>
> >
> >     Quick question: Is it guaranteed that there is no DeleteResponse here? It would
be good to at least log a warn if we get an unexpected response here.
> 
> Roger Hoover wrote:
>     It is guaranteed that you will not get a DeleteResponse back because the producer
currently only allows IndexRequests.  In the furture, if it supports DeleteRequest then we
should add a counter metric for deletes.

@Roger, thanks for the explanation. My point is: it would be good to make the code detect
and log unexpected response.


- Yi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36815/#review93395
-----------------------------------------------------------


On July 29, 2015, 5:17 a.m., Roger Hoover wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36815/
> -----------------------------------------------------------
> 
> (Updated July 29, 2015, 5:17 a.m.)
> 
> 
> Review request for samza and Dan Harvey.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-741 Add support for versioning to Elasticsearch System Producer
> 
> 
> Diffs
> -----
> 
>   samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java
f61bd36 
>   samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerMetrics.java
e3b635b 
>   samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/indexrequest/DefaultIndexRequestFactory.java
afe0eee 
>   samza-elasticsearch/src/test/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerMetricsTest.java
980964f 
>   samza-elasticsearch/src/test/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerTest.java
684d7f6 
> 
> Diff: https://reviews.apache.org/r/36815/diff/
> 
> 
> Testing
> -------
> 
> Refactored DefaultIndexRequestFactory to make it easier to subclass and customize to
handle version and version_type parameters.
> 
> 
> Thanks,
> 
> Roger Hoover
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message