samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksandar Pejakovic" <a.pejako...@levi9.com>
Subject Re: Review Request 36727: SAMZA-563 Upgrade Samza to YARN 2.6.0
Date Wed, 29 Jul 2015 08:39:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36727/
-----------------------------------------------------------

(Updated July 29, 2015, 8:39 a.m.)


Review request for samza.


Changes
-------

Fixed test in samza-yarn -> TestSamzaAppMaster -> testAppMasterShouldReboot
  - changed allocate method in TestAMRMClientImpl to throw ApplicationAttemptNotFoundException
if reboot is set to true


Repository: samza


Description
-------

Upgraded version of yarn in samza.


Diffs (updated)
-----

  bin/check-all.sh 67bf776 
  docs/contribute/tests.md f485ce2 
  docs/learn/tutorials/versioned/run-in-multi-node-yarn.md 312efaf 
  gradle/dependency-versions.gradle fb06e8e 
  samza-test/src/main/python/configs/downloads.json a75756f 
  samza-test/src/main/python/configs/yarn.json 9b0143d 
  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMaster.scala 7b7d86a 
  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala df5992e

  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala
1e936b4 

Diff: https://reviews.apache.org/r/36727/diff/


Testing
-------

All test except one in samza-yarn -> TestSamzaAppMaster -> testAppMasterShouldReboot
pass.
  - because of: [YARN-1365](https://issues.apache.org/jira/browse/YARN-1365), [YARN-1366](https://issues.apache.org/jira/browse/YARN-1366)
and [YARN-1367](https://issues.apache.org/jira/browse/YARN-1366) they changed: -> AMRMClientAsyncImpl.java
-> private class HeartbeatThread. It's method run() no longer catches ApplicationMasterNotRegisteredException
(replacement for AMCommand.AM_RESYNC) and no longer does resyncing.

Without that test everything works just fine. Tried hello-samza, works fine.


Thanks,

Aleksandar Pejakovic


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message