samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Harvey" <danharve...@gmail.com>
Subject Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer
Date Wed, 29 Jul 2015 08:42:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36815/#review93413
-----------------------------------------------------------



samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java
(line 116)
<https://reviews.apache.org/r/36815/#comment147785>

    Should we add a Samza specifc message, then add the whole exception? so it's more clear
what the exception was from if the user doesn't know the code? `Logger.info("Failed to index
message in ElasticSearch.", e);`
    
    This would also be true for other log lines added.


One comment on the logging but I think this looks great otherwise.

- Dan Harvey


On July 29, 2015, 6:22 a.m., Roger Hoover wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36815/
> -----------------------------------------------------------
> 
> (Updated July 29, 2015, 6:22 a.m.)
> 
> 
> Review request for samza and Dan Harvey.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-741 Add support for versioning to Elasticsearch System Producer
> 
> 
> Diffs
> -----
> 
>   samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java
f61bd36 
>   samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerMetrics.java
e3b635b 
>   samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/indexrequest/DefaultIndexRequestFactory.java
afe0eee 
>   samza-elasticsearch/src/test/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerMetricsTest.java
980964f 
>   samza-elasticsearch/src/test/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerTest.java
684d7f6 
> 
> Diff: https://reviews.apache.org/r/36815/diff/
> 
> 
> Testing
> -------
> 
> Refactored DefaultIndexRequestFactory to make it easier to subclass and customize to
handle version and version_type parameters.
> 
> 
> Thanks,
> 
> Roger Hoover
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message