samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navina Ramesh" <nram...@linkedin.com>
Subject Re: Review Request 36903: SAMZA-744: shutdown stores before shutdown producers
Date Fri, 07 Aug 2015 19:18:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36903/#review94572
-----------------------------------------------------------

Ship it!


lgtm!


samza-test/src/test/scala/org/apache/samza/test/integration/TestShutdownStatefulTask.scala
(line 131)
<https://reviews.apache.org/r/36903/#comment149178>

    nit: remove ';'



samza-test/src/test/scala/org/apache/samza/test/integration/TestShutdownStatefulTask.scala
(line 135)
<https://reviews.apache.org/r/36903/#comment149179>

    nit: same. remove ';'


- Navina Ramesh


On Aug. 6, 2015, 11:24 a.m., Yi Pan (Data Infrastructure) wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36903/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 11:24 a.m.)
> 
> 
> Review request for samza, Yan Fang, Chinmay Soman, Chris Riccomini, and Navina Ramesh.
> 
> 
> Bugs: SAMZA-744
>     https://issues.apache.org/jira/browse/SAMZA-744
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-744: shutdown stores before shutdown producers
> 
> 
> Diffs
> -----
> 
>   build.gradle 0852adc4e8e0c2816afd1ebf433f1af6b44852f7 
>   samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 27b2517048ad5730762506426ee7578c66181db8

>   samza-test/src/test/scala/org/apache/samza/test/integration/StreamTaskTestUtil.scala
PRE-CREATION 
>   samza-test/src/test/scala/org/apache/samza/test/integration/TestShutdownStatefulTask.scala
PRE-CREATION 
>   samza-test/src/test/scala/org/apache/samza/test/integration/TestStatefulTask.scala
ea702a919348305ff95ce0b4ca1996a13aff04ec 
> 
> Diff: https://reviews.apache.org/r/36903/diff/
> 
> 
> Testing
> -------
> 
> ./bin/check-all.sh passed
> 
> 
> Thanks,
> 
> Yi Pan (Data Infrastructure)
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message