samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksandar Bircakovic" <a.bircako...@levi9.com>
Subject Re: Review Request 37604: SAMZA-760 Samza Container should catch Throwables instead of just catching Exceptions
Date Thu, 08 Oct 2015 09:42:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37604/
-----------------------------------------------------------

(Updated Oct. 8, 2015, 9:42 a.m.)


Review request for samza.


Changes
-------

Used SamzaException(String s, Throwable t) instead of SamzaException(String s) as Yi Pan suggested.


Repository: samza


Description
-------

Added a catch for Throwables in Samza container. Catching Throwables can cause problems in
specific situations so I also added a partial function 'safely' that should take care of that
specific situations.


Diffs (updated)
-----

  samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala f351ad6 
  samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 6de8710 

Diff: https://reviews.apache.org/r/37604/diff/


Testing
-------


Thanks,

Aleksandar Bircakovic


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message