samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navina Ramesh" <nram...@linkedin.com>
Subject Re: Review Request 36768: SAMZA-740: Add ElasticsearchProducer example to samza-hello-samza
Date Mon, 19 Oct 2015 21:41:17 GMT


> On July 24, 2015, 6:18 p.m., Navina Ramesh wrote:
> > bin/grid-elastic, line 1
> > <https://reviews.apache.org/r/36768/diff/1/?file=1020797#file1020797line1>
> >
> >     Can you make changes to bin/grid by adding options to install elastic_search
and/or kibana? Code seems redundant.
> 
> Stuart Davidson wrote:
>     I deliberately split it up because I didn't think that all people would want to know
how to use Elasticsearch - thus, not everyone would want to install it. I really don't think
we should combine the two - most of hello-samza talks about the core components of using Samza,
whereas this example doesn't. 
>     
>     Are you sure you want me to combine the two?

Ok. That makes sense :) Let's keep it separate.


- Navina


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36768/#review92951
-----------------------------------------------------------


On July 24, 2015, 8:31 a.m., Stuart Davidson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36768/
> -----------------------------------------------------------
> 
> (Updated July 24, 2015, 8:31 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza-hello-samza
> 
> 
> Description
> -------
> 
> I'd put together an example of how to use the new ElasticsearchProvider for my work colleagues
and I thought it'd be worth submitting it back to the community. This also includes a script
to start elasticsearch and kibana on the host - be aware, there's a 64bit version depending
on what machine you want to run against.
> 
> Also note, this is against 0.10.0 of Samza which is not released yet. I am making the
assumption that the Elasticsearch jars are bundled as part of that - if not, we'll need to
add them to the POM here.
> 
> 
> Diffs
> -----
> 
>   bin/grid-elastic PRE-CREATION 
>   pom.xml f9c4fa9 
>   src/main/assembly/src.xml f57fee2 
>   src/main/config/wikipedia-elastic.properties PRE-CREATION 
>   src/main/java/samza/examples/wikipedia/task/WikipediaElasticStreamTask.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/36768/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stuart Davidson
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message