samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navina Ramesh" <nram...@linkedin.com>
Subject Re: Review Request 39999: SAMZA-805. use full config in case of ProcessJob
Date Fri, 06 Nov 2015 01:57:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39999/#review105351
-----------------------------------------------------------

Ship it!


lgtm! :)

- Navina Ramesh


On Nov. 6, 2015, 1:53 a.m., Boris Shkolnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39999/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 1:53 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-805
>     https://issues.apache.org/jira/browse/SAMZA-805
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Currently we strip the config of all the values, except the ones required by jobCoordinator.
> But in case of ProcessJob, the process is created before the configs are read from coordinator
stream.
> It causes ProcessJob process to miss all the task.opts settings (like heap size, or debug).
> Fix: use full config in case of ProcessJob.
> Environment for commandShell will pick only required fields from the config, including
task.opts and java.home.
> 
> 
> Diffs
> -----
> 
>   samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala 4fac154709d72ab594485dad93c912b55fb1617e

> 
> Diff: https://reviews.apache.org/r/39999/diff/
> 
> 
> Testing
> -------
> 
> Tested manually by setting some non-default values into task.opts and verifying that
the local process picked it up.
> 
> 
> Thanks,
> 
> Boris Shkolnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message