samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navina Ramesh" <nram...@linkedin.com>
Subject Re: Review Request 39575: SAMZA-793 static config rewriter should be invoked in JobRunner
Date Thu, 12 Nov 2015 19:53:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39575/#review106318
-----------------------------------------------------------

Ship it!


Lgtm!

- Navina Ramesh


On Oct. 23, 2015, 12:13 a.m., Yi Pan (Data Infrastructure) wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39575/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 12:13 a.m.)
> 
> 
> Review request for samza, Yan Fang and Navina Ramesh.
> 
> 
> Bugs: SAMZA-793
>     https://issues.apache.org/jira/browse/SAMZA-793
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Move rewriter logic to JobRunner so that:
> 1. It is invoked once
> 2. It is invoked no matter which job factory is used
> 
> 
> Diffs
> -----
> 
>   samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala a926ce639dbf6776ebfb1d885621f4b6bf5f5aa5

>   samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala d6109ec4b3eedfe32325c6dc420c6c8bb18eb79b

> 
> Diff: https://reviews.apache.org/r/39575/diff/
> 
> 
> Testing
> -------
> 
> Verified via test jobs.
> 
> 
> Thanks,
> 
> Yi Pan (Data Infrastructure)
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message