samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navina Ramesh" <nram...@linkedin.com>
Subject Re: Review Request 40421: SAMZA-754: fix the null oldestOffset issue in empty topics
Date Wed, 18 Nov 2015 21:24:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40421/#review107088
-----------------------------------------------------------

Ship it!


One question. Otherwise, lgtm! :)


samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala (line 198)
<https://reviews.apache.org/r/40421/#comment166012>

    Should we do a similar check for newestOffsets?


- Navina Ramesh


On Nov. 18, 2015, 1:30 a.m., Yi Pan (Data Infrastructure) wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40421/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2015, 1:30 a.m.)
> 
> 
> Review request for samza, Yan Fang, Chinmay Soman, Chris Riccomini, and Navina Ramesh.
> 
> 
> Bugs: SAMZA-754
>     https://issues.apache.org/jira/browse/SAMZA-754
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-754: fix the null oldestOffset issue in empty topics
> 
> 
> Diffs
> -----
> 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala aee33a92941dcf686eed3fcfe7bc8ca01b1ac88b

>   samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemAdmin.scala
d260f2d776f567a19cb470100f7c3dc659df690d 
>   samza-test/src/test/scala/org/apache/samza/test/integration/StreamTaskTestUtil.scala
6e260bdd14f116fcb05c02f085ca1287bcd9f2ad 
> 
> Diff: https://reviews.apache.org/r/40421/diff/
> 
> 
> Testing
> -------
> 
> Unit test updated and passed.
> 
> 
> Thanks,
> 
> Yi Pan (Data Infrastructure)
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message