samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navina Ramesh" <nram...@linkedin.com>
Subject Re: Review Request 40457: SAMZA-788 - coordinator stream configuration should not guess the system names
Date Thu, 19 Nov 2015 22:11:35 GMT


> On Nov. 19, 2015, 5:59 p.m., Yi Pan (Data Infrastructure) wrote:
> > samza-test/src/test/scala/org/apache/samza/test/integration/TestStatefulTask.scala,
line 72
> > <https://reviews.apache.org/r/40457/diff/1/?file=1131554#file1131554line72>
> >
> >     The patch to SAMZA-754 already added this to StreamTaskTestUtils.

Fixed it and verified.


- Navina


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40457/#review107209
-----------------------------------------------------------


On Nov. 19, 2015, 10:05 p.m., Navina Ramesh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40457/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 10:05 p.m.)
> 
> 
> Review request for samza, Boris Shkolnik, Yan Fang, Chris Riccomini, Jagadish Venkatraman,
Xinyu Liu, and Yi Pan (Data Infrastructure).
> 
> 
> Bugs: SAMZA-788
>     https://issues.apache.org/jira/browse/SAMZA-788
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-788 - coordinator stream configuration should not guess the system names
> 
> 
> Diffs
> -----
> 
>   samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 6d73bb9d3ef9c95445ec7c5f539d6e6279286a73

>   samza-core/src/test/java/org/apache/samza/coordinator/stream/TestCoordinatorStreamWriter.java
f9c630419bc355d03c28e3221acde9efd8e17ae6 
>   samza-core/src/test/resources/test-migration-fail.properties b0657defeebe5ed61ebc7f1dfa7688a583071fe1

>   samza-core/src/test/resources/test.properties 41eb82eb673a82fa75f464c69000ddcde0bd17cb

> 
> Diff: https://reviews.apache.org/r/40457/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build
> 
> 
> Thanks,
> 
> Navina Ramesh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message