samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navina Ramesh" <nram...@linkedin.com>
Subject Re: Review Request 40472: SAMZA-816: avoid creating and registering CoordinatorSystemConsumer in LocalityManager in SamzaContainer
Date Thu, 19 Nov 2015 22:31:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40472/#review107253
-----------------------------------------------------------

Ship it!


A few nits. Fix them and then, +1 !


samza-core/src/main/java/org/apache/samza/container/LocalityManager.java (line 86)
<https://reviews.apache.org/r/40472/#comment166283>

    Can you add some comment/javadoc explain which components can read locality information?



samza-core/src/test/java/org/apache/samza/container/TestLocalityManager.java (line 54)
<https://reviews.apache.org/r/40472/#comment166285>

    nit: line break after test annotations
    
    This is the format everywhere else in the codebase.


cou

- Navina Ramesh


On Nov. 19, 2015, 7:46 a.m., Yi Pan (Data Infrastructure) wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40472/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 7:46 a.m.)
> 
> 
> Review request for samza, Yan Fang, Chinmay Soman, Chris Riccomini, and Navina Ramesh.
> 
> 
> Bugs: SAMZA-816
>     https://issues.apache.org/jira/browse/SAMZA-816
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-816: avoid creating and registering CoordinatorSystemConsumer in LocalityManager
in SamzaContainer
> 
> 
> Diffs
> -----
> 
>   samza-core/src/main/java/org/apache/samza/container/LocalityManager.java d19b5740069706cb98c0e59507dd7d4595aaa8b3

>   samza-core/src/main/java/org/apache/samza/coordinator/stream/AbstractCoordinatorStreamManager.java
ca97ce80d0a56e1ace3931a06bd5cf062d9516d7 
>   samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 3787b85e5cc738d16c0d1eaea4de3345a3a9106c

>   samza-core/src/test/java/org/apache/samza/container/TestLocalityManager.java PRE-CREATION

>   samza-core/src/test/java/org/apache/samza/coordinator/stream/MockCoordinatorStreamSystemFactory.java
9d8c98ed442cd893d657a580ba3794cda3aa0efa 
> 
> Diff: https://reviews.apache.org/r/40472/diff/
> 
> 
> Testing
> -------
> 
> Unit test and local builds all passed.
> 
> 
> Thanks,
> 
> Yi Pan (Data Infrastructure)
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message