samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "tao feng" <fengta...@gmail.com>
Subject Re: Review Request 40525: SAMZA-819: RocksDbKeyValueStore.flush() should be implemented
Date Fri, 20 Nov 2015 08:20:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40525/
-----------------------------------------------------------

(Updated Nov. 20, 2015, 8:20 a.m.)


Review request for samza.


Repository: samza


Description (updated)
-------

1. implement RocksDB flush method;
2. RocksDB flushOptions waitForFlush set to true;
3. unit test
 
Diff-2: Update per Yi and Navina's comments for unit test: open a read only RocksDB to verify
the data


Diffs (updated)
-----

  samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala
b949793a63951576937fa848bd674ec68f6f9727 
  samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala 4620037f2a0da43149a754aa808d3d5d280ea893

  samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala
a428a16bc1e9ab4980a6f17db4fd810057d31136 

Diff: https://reviews.apache.org/r/40525/diff/


Testing
-------

1. ./gradlew clean build
2. ./gradlew checkstyleMain checkstyleTest


Thanks,

tao feng


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message