samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>
Subject Re: Review Request 40572: SAMZA-614 - Document coordinator stream
Date Mon, 23 Nov 2015 19:31:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40572/#review107623
-----------------------------------------------------------


Thanks for putting it up. Have a few comments below.


docs/learn/documentation/versioned/container/coordinator-stream.md (line 21)
<https://reviews.apache.org/r/40572/#comment166853>

    tend to *be* pretty large.



docs/learn/documentation/versioned/container/coordinator-stream.md (line 23)
<https://reviews.apache.org/r/40572/#comment166854>

    *three* major types of messages



docs/learn/documentation/versioned/container/coordinator-stream.md (line 60)
<https://reviews.apache.org/r/40572/#comment166856>

    nit: trailing white spaces



docs/learn/documentation/versioned/container/coordinator-stream.md (line 95)
<https://reviews.apache.org/r/40572/#comment166858>

    Just to make it consistent w/ set-changelog and set-container-host-assignment, shouldn't
this be:
    {code}
    <td> 'value' => &lt;config-value&gt; </td>
    {code}



docs/learn/documentation/versioned/container/coordinator-stream.md (line 130)
<https://reviews.apache.org/r/40572/#comment166859>

    Prefer to say "HTTP API"



docs/learn/documentation/versioned/container/coordinator-stream.md (line 137)
<https://reviews.apache.org/r/40572/#comment166860>

    Is this true as for today? I thought that in today's YARN job deployment, when AppMaster
is down, the whole job is restarted (i.e. the containers will be shutdown and restarted as
well). The description here is more like a "want-to-be" state, not the current state.



docs/learn/documentation/versioned/container/coordinator-stream.md (line 147)
<https://reviews.apache.org/r/40572/#comment166861>

    One more benifit that would be huge to add to 5:
    - enables future design of JobCoordinator fail-over since it serves as the single source
of truth of current Job state.


- Yi Pan (Data Infrastructure)


On Nov. 23, 2015, 3:38 a.m., Navina Ramesh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40572/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2015, 3:38 a.m.)
> 
> 
> Review request for samza, Boris Shkolnik, Yan Fang, Chris Riccomini, Jagadish Venkatraman,
Xinyu Liu, and Yi Pan (Data Infrastructure).
> 
> 
> Bugs: SAMZA-614
>     https://issues.apache.org/jira/browse/SAMZA-614
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-614 - Document coordinator stream
> Updated configuration-table.html
> 
> 
> Diffs
> -----
> 
>   docs/learn/documentation/versioned/container/coordinator-stream.md PRE-CREATION 
>   docs/learn/documentation/versioned/container/serialization.md 6bcb641f2e3d168581274e468746f9f3078d4b8a

>   docs/learn/documentation/versioned/index.html dec5be15453a8e5794a9c66b0010803f591ed0cf

>   docs/learn/documentation/versioned/jobs/configuration-table.html b5d3813ab44062f61cb33e4b37bb7548d8ff0617

> 
> Diff: https://reviews.apache.org/r/40572/diff/
> 
> 
> Testing
> -------
> 
> Locally tested the site
> 
> 
> Thanks,
> 
> Navina Ramesh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message