samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>
Subject Re: Review Request 40624: SAMZA-775: netflix patch for memory size based throttling.
Date Tue, 24 Nov 2015 23:26:38 GMT


> On Nov. 24, 2015, 8:07 p.m., Navina Ramesh wrote:
> > samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java, line
37
> > <https://reviews.apache.org/r/40624/diff/1/?file=1137833#file1137833line37>
> >
> >     Prefer annotation here saying @VisibleForTesting
> >     
> >     What is the reasoning behind - 4 + 64 + 4 + 4 + 4?

Good point. This is also something from the experiments w/ Kafka systems as well. It may not
be applicable to all IncomingMessageEnvelope. I will try to move it to Kafka-specific classes.


> On Nov. 24, 2015, 8:07 p.m., Navina Ramesh wrote:
> > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemFactory.scala,
line 82
> > <https://reviews.apache.org/r/40624/diff/1/?file=1137838#file1137838line82>
> >
> >     Prefer to move this condition to KafkaConfig as a method - boolean isFetchLimitByBytesEnabled();

Make sense. Will do.


- Yi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40624/#review107823
-----------------------------------------------------------


On Nov. 24, 2015, 11:11 p.m., Yi Pan (Data Infrastructure) wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40624/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 11:11 p.m.)
> 
> 
> Review request for samza, Monal Daxini and Navina Ramesh.
> 
> 
> Bugs: SAMZA-775
>     https://issues.apache.org/jira/browse/SAMZA-775
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Ported the patch to 0.10
> 
> 
> Diffs
> -----
> 
>   docs/learn/documentation/versioned/jobs/configuration-table.html b5d3813ab44062f61cb33e4b37bb7548d8ff0617

>   samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java 4b143124d28308751f6725278d5afe57584c0d33

>   samza-api/src/main/java/org/apache/samza/util/BlockingEnvelopeMap.java 7dd99fb4ab435397f74644b71a4a56b9969dcde5

>   samza-api/src/test/java/org/apache/samza/util/TestBlockingEnvelopeMap.java d1a0a82d29eeef1136007f0519581f711c026b07

>   samza-kafka/src/main/scala/org/apache/samza/config/KafkaConfig.scala a65e8e8f2c3c526fa11d269ef57b1abe68ec5bc6

>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala
c948d6405f845377d16af4411a243a8cff66e81d 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemFactory.scala a60cda206130e219da8a8ba5421f2d7a45de4a81

>   samza-kafka/src/test/scala/org/apache/samza/config/TestKafkaConfig.scala 85badf9f1a8fcbf0f478c30195c59a9bbe64feb6

>   samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemConsumer.scala
23fa9398e89edeeabfd3ee754c27a8f3bec417b0 
> 
> Diff: https://reviews.apache.org/r/40624/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build passed.
> run ./bin/integration-tests.sh passed as well.
> 
> 
> Thanks,
> 
> Yi Pan (Data Infrastructure)
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message