samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "VENKATA KRISHNA NANNAPANENI" <kireetinannapan...@gmail.com>
Subject Re: Review Request 40313: SAMZA-785
Date Mon, 04 Jan 2016 16:05:57 GMT


> On Nov. 18, 2015, 9:31 p.m., Navina Ramesh wrote:
> > samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java, line
242
> > <https://reviews.apache.org/r/40313/diff/1/?file=1125434#file1125434line242>
> >
> >     What happens if serdeName is not defined at stream or system level? You should
throw an exception where a serde is not defined.
> >     
> >     Can you please change the multiple if statments to a more logic if-else statement?

I don't think it is can be an if else here (Cause of the scenarios where it has to set both).
Let me know if you still think otherwise. Thanks.


- VENKATA KRISHNA


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40313/#review107091
-----------------------------------------------------------


On Nov. 13, 2015, 10:51 p.m., VENKATA KRISHNA NANNAPANENI wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40313/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 10:51 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> check for system serde name for stream appender.
> 
> 
> Diffs
> -----
> 
>   samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java 59015a90acaf822469b0b24164e2d4c4a8000bce

>   samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java 0c6329ede9b3df4dc05125729b5b44ba2c98803a

>   samza-log4j/src/test/java/org/apache/samza/logging/log4j/TestStreamAppender.java e2e17a06159a35234270f342e8ae1c81031d971b

> 
> Diff: https://reviews.apache.org/r/40313/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> VENKATA KRISHNA NANNAPANENI
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message