> On Jan. 4, 2016, 11:14 p.m., Boris Shkolnik wrote:
> > samza-autoscaling/src/main/java/org/apache/samza/autoscaling/deployer/ConfigManager.java,
line 328
> > <https://reviews.apache.org/r/41663/diff/3/?file=1181080#file1181080line328>
> >
> > Why do we need defaultReadJobModelDelayMS?
> > If it is not specified - will still use Rand(100)?
Boris,
*defaultReadJobModelDelayMs* is hard-coded within the class. I don't think Jagadish meant
it to be configurable.
> On Jan. 4, 2016, 11:14 p.m., Boris Shkolnik wrote:
> > samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala, line
117
> > <https://reviews.apache.org/r/41663/diff/3/?file=1181082#file1181082line117>
> >
> > Where is the change to JobCoordinator constructor? Did I miss it?
>
> Yi Pan (Data Infrastructure) wrote:
> The constructor actually does not change here. The way to get the initial arguments
change.
Yep. Constructor doesn't change. jobModelGenerator() returns a JobModel instance. The constructor
is same as before.
- Navina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41663/#review112678
-----------------------------------------------------------
On Jan. 5, 2016, 12:29 a.m., Navina Ramesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41663/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 12:29 a.m.)
>
>
> Review request for samza, Boris Shkolnik, Yan Fang, Chris Riccomini, Jake Maes, Jagadish
Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-843
> https://issues.apache.org/jira/browse/SAMZA-843
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-843 : Slow start of Samza jobs with large number of containers
>
>
> Diffs
> -----
>
> samza-autoscaling/src/main/java/org/apache/samza/autoscaling/deployer/ConfigManager.java
87346bc9f3d92e3ae86ed264c82d12a4d27f3188
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala ddce1481cee41dfb997103dbe3d5df44a123564e
> samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala 112ec1c2935fb6c2ebe9b5d9090263cea94c0cf9
> samza-core/src/main/scala/org/apache/samza/coordinator/server/JobServlet.scala a3baddbe81c96f58e718e062e964485eaa2dc701
> samza-core/src/main/scala/org/apache/samza/util/Util.scala 58fbb8f8177a109d35659a29ef6660e239334de2
> samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 365ff0a8ece808a8143ee3580f1f42238dd292d1
> samza-core/src/test/scala/org/apache/samza/coordinator/TestJobCoordinator.scala 80cccf3104e6e0ce7457303f40baa2f4fa807782
>
> Diff: https://reviews.apache.org/r/41663/diff/
>
>
> Testing
> -------
>
> Added some additional unit tests
> ./gradlew clean build
>
>
> Thanks,
>
> Navina Ramesh
>
>
|