From dev-return-5190-apmail-samza-dev-archive=samza.apache.org@samza.apache.org Wed Jan 6 00:18:39 2016 Return-Path: X-Original-To: apmail-samza-dev-archive@minotaur.apache.org Delivered-To: apmail-samza-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3ED23182C3 for ; Wed, 6 Jan 2016 00:18:39 +0000 (UTC) Received: (qmail 55577 invoked by uid 500); 6 Jan 2016 00:18:39 -0000 Delivered-To: apmail-samza-dev-archive@samza.apache.org Received: (qmail 55511 invoked by uid 500); 6 Jan 2016 00:18:39 -0000 Mailing-List: contact dev-help@samza.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@samza.apache.org Delivered-To: mailing list dev@samza.apache.org Received: (qmail 55490 invoked by uid 99); 6 Jan 2016 00:18:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jan 2016 00:18:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6757D2983D1; Wed, 6 Jan 2016 00:18:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5693420791765207590==" MIME-Version: 1.0 Subject: Re: Review Request 41912: SAMZA-850: Yarn Job Validation Tool From: "Jake Maes" To: "Boris Shkolnik" , "Navina Ramesh" , "Yi Pan (Data Infrastructure)" Cc: "Jake Maes" , "samza" , "Xinyu Liu" Date: Wed, 06 Jan 2016 00:18:37 -0000 Message-ID: <20160106001837.26043.21916@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jake Maes" X-ReviewGroup: Samza X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41912/ X-Sender: "Jake Maes" References: <20160105012140.26043.20516@reviews.apache.org> In-Reply-To: <20160105012140.26043.20516@reviews.apache.org> Reply-To: "Jake Maes" X-ReviewRequest-Repository: samza --===============5693420791765207590== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41912/#review112970 ----------------------------------------------------------- Ship it! Ship It! - Jake Maes On Jan. 5, 2016, 1:21 a.m., Xinyu Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41912/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 1:21 a.m.) > > > Review request for samza, Boris Shkolnik, Navina Ramesh, and Yi Pan (Data Infrastructure). > > > Repository: samza > > > Description > ------- > > We've seen a strong need for validating running samza jobs programmatically. Consider the following scenarios: > 1) running samza as a service (as in SAMZA-849), which requires automated job validation when upgrading the framework for large number of jobs; > 2) production monitoring, automated validation can run periodically and trigger alerts; > 3) integration testing, which can use validation tool to check the job status. > > So a tool is needed to provide the checkout of job health. Minimally it will check: > - job submission > - app running > - container count > > It should also be able to extend and validate the job metrics through metrics system, such as JMX. The user will be able to validate against important metrics such as process_count or message_behind_high_watermark. > > > Diffs > ----- > > checkstyle/import-control.xml 53cb8b447240fea08d98ccfb12ed24bec6cbf67c > samza-api/src/main/java/org/apache/samza/metrics/MetricsAccessor.java PRE-CREATION > samza-api/src/main/java/org/apache/samza/metrics/MetricsValidationFailureException.java PRE-CREATION > samza-api/src/main/java/org/apache/samza/metrics/MetricsValidator.java PRE-CREATION > samza-core/src/main/java/org/apache/samza/job/model/JobModel.java 9445a30c9e605a3623873ed09eedfd5140af98f7 > samza-core/src/main/java/org/apache/samza/metrics/JmxMetricsAccessor.java PRE-CREATION > samza-core/src/main/java/org/apache/samza/metrics/JmxUtil.java PRE-CREATION > samza-core/src/main/scala/org/apache/samza/metrics/reporter/JmxReporter.scala e9661023a04f39d059d879fea2140cb57af3b546 > samza-core/src/test/java/org/apache/samza/metrics/TestJmxMetricsAccessor.java PRE-CREATION > samza-shell/src/main/bash/validate-yarn-job.sh PRE-CREATION > samza-yarn/src/main/java/org/apache/samza/validation/YarnJobValidationTool.java PRE-CREATION > samza-yarn/src/test/java/org/apache/samza/validation/MockMetricsValidator.java PRE-CREATION > samza-yarn/src/test/java/org/apache/samza/validation/TestYarnJobValidationTool.java PRE-CREATION > > Diff: https://reviews.apache.org/r/41912/diff/ > > > Testing > ------- > > Unit tests added to cover all the new methods/classes. > > > Thanks, > > Xinyu Liu > > --===============5693420791765207590==--