samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boris Shkolnik <bor...@apache.org>
Subject Re: Review Request 43550: SAMZA-836: fix unit test failure w/ FlushOptions() in rocksdbjni-3.13.1
Date Tue, 01 Mar 2016 01:10:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43550/#review121371
-----------------------------------------------------------


Ship it!




I wish we understood the reason for it.

- Boris Shkolnik


On Feb. 13, 2016, 12:13 a.m., Yi Pan (Data Infrastructure) wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43550/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2016, 12:13 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-836
>     https://issues.apache.org/jira/browse/SAMZA-836
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-836: fix unit test failure w/ FlushOptions() in rocksdbjni-3.13.1
> 
> 
> Diffs
> -----
> 
>   samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala
0c86a5a1550894645c2ab0010b70b124ad3dbd98 
> 
> Diff: https://reviews.apache.org/r/43550/diff/
> 
> 
> Testing
> -------
> 
> Ran the full set of unit tests both on Mac and Linux and both passed.
> 
> 
> Thanks,
> 
> Yi Pan (Data Infrastructure)
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message