samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jagadish Venkatraman <jagadish1...@gmail.com>
Subject Review Request 44775: SAMZA-894 : Refactor logic that handles allocated containers
Date Mon, 14 Mar 2016 05:58:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44775/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

The current container allocator has some repetitive checks - when it decides to enqueue a
container to ANY_HOST. I believe it is a good idea to eliminate those repetitive checks and
refactor the allocation logic. It will help in long-term maintainability.


Diffs
-----

  samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerRequestState.java 3e3f48ce2b5c0802e8c7c4f09b632df2d2265c12


Diff: https://reviews.apache.org/r/44775/diff/


Testing
-------

All unit tests still pass.


Thanks,

Jagadish Venkatraman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message