samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Navina Ramesh <nram...@linkedin.com>
Subject Re: Review Request 44866: SAMZA-897 fix the backward-incompatible use of getOrDefault
Date Tue, 15 Mar 2016 21:30:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44866/#review123754
-----------------------------------------------------------


Ship it!




Thanks for fixing this. Tip: You should always run ./check-all.sh on your patch before submitting
it. That would have caught this error. This should apply for committing code as well.

- Navina Ramesh


On March 15, 2016, 9:20 p.m., Jake Maes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44866/
> -----------------------------------------------------------
> 
> (Updated March 15, 2016, 9:20 p.m.)
> 
> 
> Review request for samza, Navina Ramesh, Jagadish Venkatraman, and Yi Pan (Data Infrastructure).
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-897 fix the backward-incompatible use of getOrDefault
> 
> Switched it to use getOrElse from scala map
> 
> 
> Diffs
> -----
> 
>   samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala 6ff9aaceb7107692b5233c675af9cccabc832044

> 
> Diff: https://reviews.apache.org/r/44866/diff/
> 
> 
> Testing
> -------
> 
> Built with java 7
> 
> Also searched the code to make sure there was no other usage of getOrDefault()
> 
> 
> Thanks,
> 
> Jake Maes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message