samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Navina Ramesh <nram...@linkedin.com>
Subject Re: Review Request 44405: SAMZA-882 - Detect partition count changes in input streams
Date Wed, 16 Mar 2016 04:09:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44405/
-----------------------------------------------------------

(Updated March 16, 2016, 4:09 a.m.)


Review request for samza, Boris Shkolnik, Jake Maes, Jagadish Venkatraman, Xinyu Liu, and
Yi Pan (Data Infrastructure).


Changes
-------

Simplified logic by not adding to cache when partitionsMetadataOnly. Addressed review comments.


Bugs: SAMZA-882
    https://issues.apache.org/jira/browse/SAMZA-882


Repository: samza


Description
-------

Adding loop.done in stream metadata cache


Adding comments in Test


Adding configuration to the docs


Fixing the swallowed exception from Scala immutable map


Updating config docs


Fixed some comments and javadoc


Diffs (updated)
-----

  docs/learn/documentation/versioned/jobs/configuration-table.html 2745a22daf3626db56da2bedad07690751a34a27

  samza-api/src/main/java/org/apache/samza/system/ExtendedSystemAdmin.java PRE-CREATION 
  samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 4f3e9a297ce2c0df0f5f25e0aad62f7bed774cd6

  samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala 6ff9aaceb7107692b5233c675af9cccabc832044

  samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala 06a96ad6ed786c22924017f894413bfa1ea34c06

  samza-core/src/main/scala/org/apache/samza/coordinator/StreamPartitionCountMonitor.scala
PRE-CREATION 
  samza-core/src/main/scala/org/apache/samza/system/StreamMetadataCache.scala 155c3d16d33d9bb9cd5410d786004c1bf2a57ed3

  samza-core/src/main/scala/org/apache/samza/util/Util.scala bd0fe5fc8128c59fa6d08941ad88eed66dda622b

  samza-core/src/test/scala/org/apache/samza/coordinator/TestJobCoordinator.scala 9ab1dd516871b1755ef64fa25cea47491ad781e2

  samza-core/src/test/scala/org/apache/samza/coordinator/TestStreamPartitionCountMonitor.scala
PRE-CREATION 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala 9dc436a40afd7190626a8be0d716c70e0fe83c7a

  samza-yarn/src/test/java/org/apache/samza/job/yarn/TestContainerAllocator.java 2b1bdab3c8de3184e930c244a8cae55813c33565

  samza-yarn/src/test/java/org/apache/samza/job/yarn/TestHostAwareContainerAllocator.java
0c7a09f3e4c4c2ce6788be729d0bf4a294243c68 
  samza-yarn/src/test/java/org/apache/samza/job/yarn/TestSamzaTaskManager.java 9da1edf6ff165ef0306de8730853ad30551a9831


Diff: https://reviews.apache.org/r/44405/diff/


Testing
-------

./gradlew clean build
Tested with a simple Samza job using hello-samza -> Verified that the metrics gauge is
getting updated and published correctly.


Thanks,

Navina Ramesh


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message