samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jagadish Venkatraman <jagadish1...@gmail.com>
Subject Review Request 45063: SAMZA-903
Date Sat, 19 Mar 2016 00:29:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45063/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

As a part of the refactoring we separate out Samza specific state and Yarn specific state.
As a result, the class SamzaAppState is moved from samza-yarn to samza-core.
The variables in the old SamzaAppState are now split into 
i) Refactored SamzaAppState (in samza core)
ii)YarnAppState (in samza yarn)
Hence, we will need to change the references to SamzaAppState in all the UI scala template
classes to work with the newer refactoring. This RB creates a scalatev2 directory that will
include the refactored templates.

This RB depends on RB:44920 

Review tools does not support a way to upload a diff against some already existing change-list.
Hence, this RB is deceptively large.


Diffs
-----

  build.gradle 16facbbf4dff378c561461786ff186bd9e0000ed 
  samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java
PRE-CREATION 
  samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
PRE-CREATION 
  samza-core/src/main/java/org/apache/samza/clustermanager/ContainerAllocator.java PRE-CREATION

  samza-core/src/main/java/org/apache/samza/clustermanager/ContainerManagerFactory.java PRE-CREATION

  samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java PRE-CREATION

  samza-core/src/main/java/org/apache/samza/clustermanager/ContainerRequestState.java PRE-CREATION

  samza-core/src/main/java/org/apache/samza/clustermanager/HostAwareContainerAllocator.java
PRE-CREATION 
  samza-core/src/main/java/org/apache/samza/clustermanager/ResourceFailure.java PRE-CREATION

  samza-core/src/main/java/org/apache/samza/clustermanager/SamzaAppState.java PRE-CREATION

  samza-core/src/main/java/org/apache/samza/clustermanager/SamzaContainerLaunchException.java
PRE-CREATION 
  samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResource.java PRE-CREATION

  samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResourceRequest.java PRE-CREATION

  samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResourceStatus.java PRE-CREATION

  samza-core/src/main/java/org/apache/samza/clustermanager/SamzaTaskManager.java PRE-CREATION

  samza-core/src/main/java/org/apache/samza/config/ClusterManagerConfig.java PRE-CREATION

  samza-core/src/main/scala/org/apache/samza/coordinator/JobModelReader.scala PRE-CREATION

  samza-core/src/main/scala/org/apache/samza/metrics/SamzaAppMasterMetrics.scala PRE-CREATION

  samza-shell/src/main/bash/run-am.sh 9545a96953baaff17ad14962e02bc12aadbb1101 
  samza-yarn/src/main/java/org/apache/samza/job/yarn/refactor/YarnAppState.java PRE-CREATION

  samza-yarn/src/main/java/org/apache/samza/job/yarn/refactor/YarnContainerManager.java PRE-CREATION

  samza-yarn/src/main/java/org/apache/samza/job/yarn/refactor/YarnContainerManagerFactory.java
PRE-CREATION 
  samza-yarn/src/main/java/org/apache/samza/job/yarn/refactor/YarnContainerRunner.java PRE-CREATION

  samza-yarn/src/main/resources/scalatev2/WEB-INF/layouts/default.scaml PRE-CREATION 
  samza-yarn/src/main/resources/scalatev2/WEB-INF/views/index.scaml PRE-CREATION 
  samza-yarn/src/main/resources/scalatev2/css/bootstrap.min.css PRE-CREATION 
  samza-yarn/src/main/resources/scalatev2/css/font-awesome.min.css PRE-CREATION 
  samza-yarn/src/main/resources/scalatev2/css/ropa-sans.css PRE-CREATION 
  samza-yarn/src/main/resources/scalatev2/fonts/FontAwesome.otf PRE-CREATION 
  samza-yarn/src/main/resources/scalatev2/fonts/RopaSans-Regular-webfont.woff PRE-CREATION

  samza-yarn/src/main/resources/scalatev2/fonts/fontawesome-webfont.eot PRE-CREATION 
  samza-yarn/src/main/resources/scalatev2/fonts/fontawesome-webfont.svg PRE-CREATION 
  samza-yarn/src/main/resources/scalatev2/fonts/fontawesome-webfont.ttf PRE-CREATION 
  samza-yarn/src/main/resources/scalatev2/fonts/fontawesome-webfont.woff PRE-CREATION 
  samza-yarn/src/main/resources/scalatev2/fonts/glyphicons-halflings-regular.eot PRE-CREATION

  samza-yarn/src/main/resources/scalatev2/fonts/glyphicons-halflings-regular.svg PRE-CREATION

  samza-yarn/src/main/resources/scalatev2/fonts/glyphicons-halflings-regular.ttf PRE-CREATION

  samza-yarn/src/main/resources/scalatev2/fonts/glyphicons-halflings-regular.woff PRE-CREATION

  samza-yarn/src/main/resources/scalatev2/img/asc.gif PRE-CREATION 
  samza-yarn/src/main/resources/scalatev2/img/bg.gif PRE-CREATION 
  samza-yarn/src/main/resources/scalatev2/img/desc.gif PRE-CREATION 
  samza-yarn/src/main/resources/scalatev2/img/samza-icon.png PRE-CREATION 
  samza-yarn/src/main/resources/scalatev2/js/bootstrap.min.js PRE-CREATION 
  samza-yarn/src/main/resources/scalatev2/js/jquery-1.11.1.min.js PRE-CREATION 
  samza-yarn/src/main/resources/scalatev2/js/jquery.tablesorter.min.js PRE-CREATION 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnAppMasterListener.scala 6bf3046a1ae4ed8f57500acae763184084ad0e09

  samza-yarn/src/main/scala/org/apache/samza/job/yarn/refactor/SamzaAppMasterService.scala
PRE-CREATION 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/refactor/SamzaYarnAppMasterLifecycle.scala
PRE-CREATION 
  samza-yarn/src/main/scala/org/apache/samza/webapp/refactor/ApplicationMasterRestServlet.scala
PRE-CREATION 
  samza-yarn/src/main/scala/org/apache/samza/webapp/refactor/ApplicationMasterWebServlet.scala
PRE-CREATION 
  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala 30cf34fe1fd3f74537d16e8a51b467cd50835357

  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterService.scala 7f5d9f4af088589d4287c26737bae25567c157d7


Diff: https://reviews.apache.org/r/45063/diff/


Testing
-------

Created a sample job and verified that the UI is still displayed.


Thanks,

Jagadish Venkatraman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message