samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Navina Ramesh <nram...@linkedin.com>
Subject Re: Review Request 45136: SAMZA-905 Host Affinity - State restore doesn't work if the previous shutdown was uncontrolled
Date Thu, 24 Mar 2016 20:34:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45136/#review125332
-----------------------------------------------------------


Ship it!




Sorry for the late review. Changes look good. +1

- Navina Ramesh


On March 24, 2016, 12:30 a.m., Jake Maes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45136/
> -----------------------------------------------------------
> 
> (Updated March 24, 2016, 12:30 a.m.)
> 
> 
> Review request for samza, Navina Ramesh, Jagadish Venkatraman, and Yi Pan (Data Infrastructure).
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Add continuous checkpointing. 
> The offset file is now written on each commit
> 
> 
> Diffs
> -----
> 
>   docs/learn/documentation/versioned/yarn/yarn-host-affinity.md 1d9c29e7ee7fd19fabba55111b5088cc5d36f1fe

>   samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala 422799a099dd391a50f934fe65d5b37471264af6

>   samza-core/src/test/scala/org/apache/samza/storage/TestTaskStorageManager.scala f08e8ddd6fc3b2cbf4ca195f22049d368abe6e62

> 
> Diff: https://reviews.apache.org/r/45136/diff/
> 
> 
> Testing
> -------
> 
> New unit tests and a test job. With the test job set to autocommit, I was able to see
the OFFSET file get written every commit.
> 
> 
> Thanks,
> 
> Jake Maes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message