samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jagadish Venkatraman <jagadish1...@gmail.com>
Subject Re: Review Request 45387: SAMZA-919 - Hello Samza - Add milliseconds and thread name to log4j config
Date Mon, 28 Mar 2016 17:22:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45387/#review125681
-----------------------------------------------------------


Ship it!




LGTM.. Please could you fill-in the testing done section?  I'm assuming the hello-world runs
with the expected log output. Thanks!

- J

- Jagadish Venkatraman


On March 28, 2016, 4:36 p.m., Jake Maes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45387/
> -----------------------------------------------------------
> 
> (Updated March 28, 2016, 4:36 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza-hello-samza
> 
> 
> Description
> -------
> 
> Add milliseconds and thread name to log4j config
> 
> 
> Diffs
> -----
> 
>   src/main/resources/log4j.xml 129149ffe84c9605d929deb8edec553955535c34 
> 
> Diff: https://reviews.apache.org/r/45387/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jake Maes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message