samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branislav Cogic <b.co...@levi9.com>
Subject Re: Review Request 51516: SAMZA-702: Document the significance of all the different metrics emitted by Samza out of the box
Date Fri, 02 Sep 2016 09:17:28 GMT


> On Sept. 1, 2016, 1:50 a.m., Navina Ramesh wrote:
> > docs/learn/documentation/versioned/container/metrics-table.html, line 795
> > <https://reviews.apache.org/r/51516/diff/1/?file=1488430#file1488430line795>
> >
> >     did you mean per-system here?

No, i meant per system strea. Maybe the description was confusing so i changed it a little
bit. I hope I am not misunderstanding this metric.


- Branislav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51516/#review147523
-----------------------------------------------------------


On Sept. 2, 2016, 9:10 a.m., Branislav Cogic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51516/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2016, 9:10 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-702
>     https://issues.apache.org/jira/browse/SAMZA-702
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> All the metrics documented in a metrics-table.
> 
> Few counters and timer removed because they are not used:
> - "send-calls" counter and "chooser-update-ns" timer from SamzaContainerMetrics
> - "batch-resets" counter from BootstrapingChooserMetrics
> - "producer-retries" marked as deprecated in KafkaSystemProducerMetrics
> 
> 
> Diffs
> -----
> 
>   docs/_layouts/default.html 7beb734ddeaecb7a6369f7d2a5d4e0c67655269c 
>   docs/learn/documentation/versioned/container/metrics-table.html PRE-CREATION 
>   docs/learn/documentation/versioned/container/metrics.md b053b792097400536ea385cb3db720f6f71da017

>   samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala 1e7515e8e8eb5ff2f769bea3184ce49308bada9a

>   samza-core/src/main/scala/org/apache/samza/container/TaskInstanceMetrics.scala 7bedadf6597524aeca3484f1cf70ea6889452496

>   samza-core/src/main/scala/org/apache/samza/system/chooser/BootstrappingChooser.scala
1cd8e0637e2192460a9e9fe078c735444be8eb97 
>   samza-core/src/main/scala/org/apache/samza/task/TaskInstanceCollector.scala 3b91180eb231c5010b7e5a66ba990257717ca508

>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducerMetrics.scala
d579e7bdf151ba5e2a6b3956ceb8a50c8e8026a6 
>   samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala
fab998a37ad1f9c08693684ddf6354aeea43de74 
> 
> Diff: https://reviews.apache.org/r/51516/diff/
> 
> 
> Testing
> -------
> 
> Site ran locally using local-site-test.sh
> ./gradlew clean build
> ./gradlew checkstyleMain checkstyleTest
> 
> 
> Thanks,
> 
> Branislav Cogic
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message