samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Navina Ramesh <nram...@linkedin.com>
Subject Re: Review Request 51726: SAMZA-1005: Refactor class instantiation code to a helper class.
Date Sat, 10 Sep 2016 23:37:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51726/#review148401
-----------------------------------------------------------


Ship it!




Patch looks awesome! I think you got most of the occurrences of Class loaders :) Thanks for
the patch!

- Navina Ramesh


On Sept. 8, 2016, 12:44 p.m., Branislav Cogic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51726/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2016, 12:44 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-1005
>     https://issues.apache.org/jira/browse/SAMZA-1005
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Refactor class instantiation code to a helper class
> 
> 
> Diffs
> -----
> 
>   samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java
c6bfec00691270a443d94b2b48569b6f01b69489 
>   samza-core/src/main/java/org/apache/samza/util/ClassLoaderHelper.java PRE-CREATION

>   samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala f786fc08c8f7eced4f4084dc8326b288888b6422

>   samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala 383bb13b18ace639607541c1bf6d0f42569cd4ff

>   samza-core/src/main/scala/org/apache/samza/util/CommandLine.scala f26501b2820b99d1ad2964c6f7833ef7eaddba97

>   samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java 75f3867281240e821bc847eb21a83bb891be6667

>   samza-rest/src/main/java/org/apache/samza/rest/SamzaRestApplication.java 61f3c462b61e531a566f885c5955c178ad25226b

>   samza-rest/src/main/java/org/apache/samza/rest/proxy/job/AbstractJobProxy.java bcc88d0fc1ab7a3d3010815c69820ab292ac42f2

>   samza-yarn/src/main/java/org/apache/samza/validation/YarnJobValidationTool.java c47e8d1214763ba1cac4ca31322746107a5f1260

> 
> Diff: https://reviews.apache.org/r/51726/diff/
> 
> 
> Testing
> -------
> 
> Ran those commands successfully on Linux:
> ./gradlew clean build
> ./gradlew checkstyleMain checkstyleTest
> ./bin/check-all.sh
> 
> And ran hello-samza jobs successfully.
> 
> 
> Thanks,
> 
> Branislav Cogic
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message