samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jagadish Venkatraman <>
Subject Review Request 51819: SAMZA-1015 Add support for streams, Lambdas and other JDK 8 like features in checkstyle
Date Mon, 12 Sep 2016 19:28:27 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina Ramesh, Xinyu Liu,
and Yi Pan (Data Infrastructure).

Repository: samza


Currently, the version of checkStyle that we use does not support features like streams, lambdas
and other JDK 8 features. Using some of these features will cause our check-all script to
According to we should be upgrading our
checkStyle version to be 5.9 or higher. (5.9 has support for checking style for JDK 8 features).

In this RB:
- Added a new property lineWrappingIndent = 2 (to guarantee 2 space indents.) The default
lineWrapping indent is 4 (which caused checkstyle failures in when
upgrading to 5.9)
- Also fixed some checkStyle incompatibilities in the existing Samza code base (These should
have ideally been caught by the older version of the checkstyle plugin we were using.)

Compatibility notes:
 - Note that checkStyle 5.9 is also compatible with older JDKs.


  build.gradle 004c81e9173c22dee3e282aad2a58a34a3e46fe2 
  checkstyle/checkstyle.xml 770b5e7f7a091198bbf53b3908600f9ac0caa4c7 16e1f5d43f0415c511689480f8cb67d84e2baadf 
  samza-core/src/test/java/org/apache/samza/container/ 9661885c1278c0d1cf53aae61f502ae719adfd51




`./gradlew build` passes successfully.


Jagadish Venkatraman

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message