samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boris Shkolnik <bor...@apache.org>
Subject Re: Review Request 52140: added docs for split deployment
Date Thu, 22 Sep 2016 23:37:23 GMT


> On Sept. 22, 2016, 1:07 a.m., Xinyu Liu wrote:
> > docs/learn/documentation/versioned/operations/split-deployment.md, line 48
> > <https://reviews.apache.org/r/52140/diff/1/?file=1507623#file1507623line48>
> >
> >     seems here are two "split deployment" bullets here. Do we want to distinguish
the second and third type of deployments by naming?

well, they both are split deployment, and the difference is in the description. Otherwise
we'll endup repeating parts of the description. I can add '1' and '2' but that is kind of
useless.


> On Sept. 22, 2016, 1:07 a.m., Xinyu Liu wrote:
> > docs/learn/documentation/versioned/operations/split-deployment.md, line 65
> > <https://reviews.apache.org/r/52140/diff/1/?file=1507623#file1507623line65>
> >
> >     1. => 2.

this is md format. It will convert second '1' into '2', and third '1' into 3.


> On Sept. 22, 2016, 1:07 a.m., Xinyu Liu wrote:
> > docs/learn/documentation/versioned/operations/split-deployment.md, line 90
> > <https://reviews.apache.org/r/52140/diff/1/?file=1507623#file1507623line90>
> >
> >     Since this is 0.11 release, can we use 0.11.0 acrose all examples here?

Sure.


> On Sept. 22, 2016, 1:07 a.m., Xinyu Liu wrote:
> > docs/learn/documentation/versioned/operations/split-deployment.md, line 113
> > <https://reviews.apache.org/r/52140/diff/1/?file=1507623#file1507623line113>
> >
> >     I think we need to mention the framework libraries needed to be placed to each
node in the cluster.

we are talking about 206 jars! how do you mention it here? I guess the user should figure
it out by themselves (for example copy from a current deployment).


- Boris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52140/#review149931
-----------------------------------------------------------


On Sept. 22, 2016, 12:48 a.m., Boris Shkolnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52140/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 12:48 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> added docs for split deployment
> 
> 
> Diffs
> -----
> 
>   docs/learn/documentation/versioned/operations/split-deployment.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52140/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Boris Shkolnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message