samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Xinyu Liu <xinyuliu...@gmail.com>
Subject Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference
Date Thu, 29 Sep 2016 19:04:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52403/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

Current the error log happens after produce close and reset the exception in later callbacks,
which caused the trouble shooting to be harder in cases of multithreading. We should log error
before closing and keep atomic reference of the initial exception.


Diffs
-----

  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 5ff6d3caf54ed148aa40c7c752c587e556a4f34a


Diff: https://reviews.apache.org/r/52403/diff/


Testing
-------

Tested in jobs deployed in Yarn cluster.


Thanks,

Xinyu Liu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message