From dev-return-6936-apmail-samza-dev-archive=samza.apache.org@samza.apache.org Thu Sep 29 18:42:49 2016 Return-Path: X-Original-To: apmail-samza-dev-archive@minotaur.apache.org Delivered-To: apmail-samza-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 17EF819743 for ; Thu, 29 Sep 2016 18:42:49 +0000 (UTC) Received: (qmail 5553 invoked by uid 500); 29 Sep 2016 18:42:48 -0000 Delivered-To: apmail-samza-dev-archive@samza.apache.org Received: (qmail 5488 invoked by uid 500); 29 Sep 2016 18:42:48 -0000 Mailing-List: contact dev-help@samza.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@samza.apache.org Delivered-To: mailing list dev@samza.apache.org Received: (qmail 5475 invoked by uid 99); 29 Sep 2016 18:42:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Sep 2016 18:42:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 01E912CAC6F; Thu, 29 Sep 2016 18:42:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3816604922772197917==" MIME-Version: 1.0 Subject: Re: Review Request 52402: SAMZA-1020: Remove some deprecated interfaces from 0.10 version From: Jagadish Venkatraman To: Jagadish Venkatraman , Xinyu Liu , samza Date: Thu, 29 Sep 2016 18:42:47 -0000 Message-ID: <20160929184247.8246.20928@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jagadish Venkatraman X-ReviewGroup: Samza X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/52402/ X-Sender: Jagadish Venkatraman X-ReviewBoard-ShipIt: 1 References: <20160929183102.1641.59589@reviews.apache.org> In-Reply-To: <20160929183102.1641.59589@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Jagadish Venkatraman X-ReviewRequest-Repository: samza --===============3816604922772197917== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52402/#review150897 ----------------------------------------------------------- Ship it! Ship It! - Jagadish Venkatraman On Sept. 29, 2016, 6:31 p.m., Xinyu Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52402/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2016, 6:31 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Remove the deprecated the methods in kafka checkpoint classes. > > > Diffs > ----- > > samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointLogKey.scala ea8462dc10d0c98fe99215e6b6b9d59cce4bcffa > samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala ea10cae82f2900c185c8c814f48dc02bbcb45621 > samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TeskKafkaCheckpointLogKey.scala c360b6c74ff924311f350df2e49424351a5c8d07 > > Diff: https://reviews.apache.org/r/52402/diff/ > > > Testing > ------- > > ./gradlew build > > > Thanks, > > Xinyu Liu > > --===============3816604922772197917==--