samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shanthoosh Venkataraman <santhoshvenkat1...@gmail.com>
Subject Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.
Date Tue, 04 Oct 2016 22:03:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52492/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

This patch contains the samza-rest monitor that periodically cleans up the stale local stores
of dead jobs/tasks. It performs the store deletion in two phases. Initially it deletes the
offset file in the local task stores if the following condition is true. ((jobIsNotRunning
|| preferedHost != nmHost) && offsetFilelastModifiedTime is greater than deleteRetention).
During the subsequent run, it deletes the local task stores if it does not contain offset
file. Please refer to the design doc of SAMZA-656 (https://issues.apache.org/jira/secure/attachment/12828083/DESIGN-SAMZA-656.pdf)
for more details.


Diffs
-----

  build.gradle 2bea27b75288d3103178bc3762b9556f6e69cdd1 
  samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitor.java PRE-CREATION 
  samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitorConfig.java PRE-CREATION

  samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitorFactory.java PRE-CREATION

  samza-rest/src/main/java/org/apache/samza/rest/model/Partition.java PRE-CREATION 
  samza-rest/src/main/java/org/apache/samza/rest/model/Task.java PRE-CREATION 
  samza-rest/src/test/java/org/apache/samza/monitor/TestLocalStoreMonitor.java PRE-CREATION


Diff: https://reviews.apache.org/r/52492/diff/


Testing
-------

Unit testing and manual testing are done to verify the functionality.


Thanks,

Shanthoosh Venkataraman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message