samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shanthoosh Venkataraman <santhoshvenkat1...@gmail.com>
Subject Re: Review Request 52476: Do not load task store which are older than delete tombstones.
Date Tue, 04 Oct 2016 23:33:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52476/
-----------------------------------------------------------

(Updated Oct. 4, 2016, 11:33 p.m.)


Review request for samza.


Repository: samza


Description
-------

Every local task store is backed up by a kafka changelog topic. Due to log compaction, delete
tombstones of the changelog topic have a ttl of delete.retention.ms. Replaying the events
from the changelog that has missing delete tombstones, would result in creation of an inconsistent
local store(due to the missing of some delete events). This patch deletes the local stores
in which difference between current time and last modified time of the offset file is greater
than delete.retention.ms during the container startup.


Diffs (updated)
-----

  samza-core/src/main/java/org/apache/samza/storage/StorageRecovery.java 9329edf7d724f3a0d9235354bb77936f713e3b5f

  samza-core/src/main/scala/org/apache/samza/config/StorageConfig.scala be3f1068f7921c9c8f8697577efea6580672813e

  samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 05a996c98075ea8ed3767af666b9beeb1933f2a6

  samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala 0b7bcdda1639eea8239a69c31bdf42558e9077d2

  samza-core/src/test/scala/org/apache/samza/storage/TestTaskStorageManager.scala 4d40f520e54beb643acd8410c772b75e2f6a9162


Diff: https://reviews.apache.org/r/52476/diff/


Testing
-------

Unit testing and manual testing has been done to verify the functionality.


Thanks,

Shanthoosh Venkataraman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message