samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Prateek Maheshwari <pmaheshw...@linkedin.com>
Subject Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference
Date Tue, 18 Oct 2016 20:57:14 GMT


> On Sept. 29, 2016, 2:30 p.m., Prateek Maheshwari wrote:
> > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala,
line 220
> > <https://reviews.apache.org/r/52403/diff/2/?file=1516385#file1516385line220>
> >
> >     If the intention is to allow user to ensure that the container doesn't die on
producer failures, shouldn't this not throw either? If we end up flushing right after the
callback exception, the user will not get a chance to ignore the exception.

Someone ran into this issue today.


- Prateek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52403/#review150947
-----------------------------------------------------------


On Sept. 29, 2016, 2:23 p.m., Xinyu Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52403/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2016, 2:23 p.m.)
> 
> 
> Review request for samza, Navina Ramesh and Jagadish Venkatraman.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Current the error log happens after produce close and reset the exception in later callbacks,
which caused the trouble shooting to be harder in cases of multithreading. We should log error
before closing and keep atomic reference of the initial exception.
> 
> 
> Diffs
> -----
> 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala
5ff6d3caf54ed148aa40c7c752c587e556a4f34a 
> 
> Diff: https://reviews.apache.org/r/52403/diff/
> 
> 
> Testing
> -------
> 
> Tested in jobs deployed in Yarn cluster.
> 
> 
> Thanks,
> 
> Xinyu Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message