samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fred Ji <...@linkedin.com>
Subject Re: Review Request 53002: Do not load the monitor, if the MonitorFactoryClass is not defined for the monitor in the config.
Date Tue, 18 Oct 2016 23:11:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53002/#review153208
-----------------------------------------------------------


Ship it!





samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java (line 71)
<https://reviews.apache.org/r/53002/#comment222498>

    nit: this line of comment is not needed since log warn is very clear.


- Fred Ji


On Oct. 18, 2016, 10:53 p.m., Shanthoosh Venkataraman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53002/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2016, 10:53 p.m.)
> 
> 
> Review request for samza and Jake Maes.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> This patch aims to not load the monitors if the monitor factory class is not defined(set)
for the monitor in the config. This will enable the users to turn on/off the monitors in samza-rest
easily(just by setting the monitorFactoryClass config associated with monitor a to empty string.)
> 
> 
> Diffs
> -----
> 
>   samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java ce947f7ae1175acc1ee9aa75991c726848072694

>   samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java 4618b54f5af861383df45bf7185622d36d17cd5e

>   samza-rest/src/test/java/org/apache/samza/monitor/mock/MockMonitorFactory.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/53002/diff/
> 
> 
> Testing
> -------
> 
> Unit testing and manual testing are done to verify the functionality.
> 
> 
> Thanks,
> 
> Shanthoosh Venkataraman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message