samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shanthoosh Venkataraman <santhoshvenkat1...@gmail.com>
Subject Re: Review Request 53002: Do not load the monitor, if the MonitorFactoryClass is not defined for the monitor in the config.
Date Wed, 19 Oct 2016 18:00:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53002/
-----------------------------------------------------------

(Updated Oct. 19, 2016, 6 p.m.)


Review request for samza and Jake Maes.


Repository: samza


Description (updated)
-------

This patch aims to not load the monitors if the monitor factory class is not defined(set)
for the monitor in the config. This will enable the users to turn on/off the monitors in samza-rest
easily(just by setting the monitorFactoryClass config associated with monitor a to empty string.).
This is associated with the JIRA ticket : https://issues.apache.org/jira/browse/SAMZA-1039


Diffs
-----

  build.gradle 98839f2d44569cfe04f12207117668afd593b4df 
  samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java ce947f7ae1175acc1ee9aa75991c726848072694

  samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java 4618b54f5af861383df45bf7185622d36d17cd5e

  samza-rest/src/test/java/org/apache/samza/monitor/mock/MockMonitorFactory.java PRE-CREATION


Diff: https://reviews.apache.org/r/53002/diff/


Testing
-------

Unit testing and manual testing are done to verify the functionality.


Thanks,

Shanthoosh Venkataraman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message