samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Pan \(Data Infrastructure\)" <yi...@linkedin.com>
Subject Re: Review Request 56911: SAMZA-1099: Documentation updates for Samza 0.12 release (for 0.12.0 branch)
Date Wed, 22 Feb 2017 08:06:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56911/#review166334
-----------------------------------------------------------


Fix it, then Ship it!




Overall looks good. Fix the nits and feel free to ship it.

A few points:
- please do another thorough grep to find all "0.11.0" or "0.11.1-SNAPSHOT" to see whether
there is anything we might missed in the documentation updates
- As a rule-of-thumb, in the versioned doc updates, all official package versions we refer
to should be "0.12.0". The only exception would be the document talking about local build
and deploy (i.e. "dev" build from the trunk, like in hello-samza and samza-rest document),
which should use "0.13.0-SNAPSHOT".


docs/learn/tutorials/versioned/run-in-multi-node-yarn.md (line 84)
<https://reviews.apache.org/r/56911/#comment238278>

    From gradle/dependency-versions-scala-2.11.gradle, we are using scala lib 2.11.8



docs/learn/tutorials/versioned/samza-rest-getting-started.md (line 34)
<https://reviews.apache.org/r/56911/#comment238284>

    remove "It" before "To".



docs/startup/download/index.md (line 100)
<https://reviews.apache.org/r/56911/#comment238281>

    It would be nice to mentioned that Samza versions less than 0.12 should use artifacts
w/ scala version 2.10 as suffix, e.g. 
    <artifactId>samza-yarn_2.10</artifactId>
    <version>0.11.0</version>



docs/startup/hello-samza/versioned/index.md (line 63)
<https://reviews.apache.org/r/56911/#comment238282>

    This section is talking about "dev" build of hello-samza, w/ PR#59 checked in, we should
refer to hello-samza-0.13.0-SNAPSHOT-dist.tar.gz here now.


- Yi Pan (Data Infrastructure)


On Feb. 22, 2017, 3:39 a.m., Jagadish Venkatraman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56911/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2017, 3:39 a.m.)
> 
> 
> Review request for samza, Jake Maes, Navina Ramesh, Prateek Maheshwari, Xinyu Liu, and
Yi Pan (Data Infrastructure).
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-1099: Documentation updates for Samza 0.12 release (for 0.12.0 branch)
> 
> 
> Diffs
> -----
> 
>   docs/_config.yml 2b5bf059f5d1c67fb9bddf6f9cf1fc606a73b428 
>   docs/learn/tutorials/versioned/deploy-samza-job-from-hdfs.md 6f7dcc1107b9b2ad5ab83449efbe9780a600700c

>   docs/learn/tutorials/versioned/deploy-samza-to-CDH.md fff209f558aceb4069e40b533e4f3ae8d1419df0

>   docs/learn/tutorials/versioned/remote-debugging-samza.md 7cc3a0ebf59f76e2191df7b0ddc6cb690b80bba6

>   docs/learn/tutorials/versioned/run-in-multi-node-yarn.md 7e7ba8de537c2b28e581ba6f369ab147a74cddc6

>   docs/learn/tutorials/versioned/samza-rest-getting-started.md c0e1cf5eb1aba5cd87a62cbc3248336e47072b7b

>   docs/startup/download/index.md 7dfdfda21caf874b72f45e2e25db6ad9980b8342 
>   docs/startup/hello-samza/versioned/index.md d0aca547cfbf38aaa24ef0d2c6cf3b29a17fb64b

> 
> Diff: https://reviews.apache.org/r/56911/diff/
> 
> 
> Testing
> -------
> 
> - Built and verified that all versions of the website (0.12,0.11,0.10, latest) were displaying
correctly.
> 
> 
> Thanks,
> 
> Jagadish Venkatraman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message