samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boris Shkolnik <bor...@apache.org>
Subject Re: Review Request 58866: fixed SAMZA-1248. use processor id for stand alone barrier
Date Sun, 30 Apr 2017 20:37:25 GMT


> On April 29, 2017, 12:23 a.m., Navina Ramesh wrote:
> > samza-core/src/main/java/org/apache/samza/zk/ZkJobCoordinator.java
> > Line 65 (original), 65 (patched)
> > <https://reviews.apache.org/r/58866/diff/1/?file=1703683#file1703683line65>
> >
> >     Why is newJobModel useful? Please add some comments as it is not very obvious.

Sure. It is needed for implementation of JobCoordinator.getJobModel(), to avoid extra calles
to ZK.


- Boris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58866/#review173409
-----------------------------------------------------------


On April 28, 2017, 11:54 p.m., Boris Shkolnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58866/
> -----------------------------------------------------------
> 
> (Updated April 28, 2017, 11:54 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-1248
>     https://issues.apache.org/jira/browse/SAMZA-1248
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> use processor id for stand alone barrier
> 
> 
> Diffs
> -----
> 
>   samza-core/src/main/java/org/apache/samza/zk/ZkJobCoordinator.java 2535654cee37feeb472517b8673a7bb12b3cc1fc

>   samza-core/src/main/java/org/apache/samza/zk/ZkUtils.java fee840511fbc19da2e19525a97fcfb5812a70a53

>   samza-core/src/test/java/org/apache/samza/zk/TestZkUtils.java b8dc2953ead2fb11fa22db5ec30b19a74a779830

> 
> 
> Diff: https://reviews.apache.org/r/58866/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Boris Shkolnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message