samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shanthoosh <...@git.apache.org>
Subject [GitHub] samza pull request #246: Samza-1364: Handle ZKExceptions in zkCoordinationUt...
Date Thu, 20 Jul 2017 16:50:37 GMT
GitHub user shanthoosh opened a pull request:

    https://github.com/apache/samza/pull/246

    Samza-1364: Handle ZKExceptions in zkCoordinationUtils.reset.

    In some cases LocalAppRunner.waitForFinish indefinitely blocks after LocalApplicationRunner.kill.
Last step in LocalAppRunner.kill(streamApp) is zkClient.close()[zkClient belongs to ZkCoordinationService].
    
    ApplicationRunner.kill triggers listeners chain and in final listener zkClient.close throws
ZkInterruptedException(RuntimeException) & it's swallowed in listeners preventing shutdownLatch
update in LocalApplicationRunner(required for proper shutdown).


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shanthoosh/samza SAMZA-1364

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/246.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #246
    
----
commit 9ced8b36c74380add0c9ba3874d679c1e5dcb5b6
Author: Shanthoosh Venkataraman <svenkataraman@linkedin.com>
Date:   2017-07-20T02:12:36Z

    Samza-1364: Handle exceptions in zkUtils.close.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message